Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devpi-server: fix tests #100508

Merged
merged 1 commit into from Oct 16, 2020
Merged

devpi-server: fix tests #100508

merged 1 commit into from Oct 16, 2020

Conversation

@jfroche
Copy link
Contributor

@jfroche jfroche commented Oct 14, 2020

Tests relied on a function that has no order guarantee. A fix was merged
to devpi master [1]. We point the package to this commit which should fix
the failing tests on hydra.

[1] devpi/devpi#821

ZHF: #97479
cc @NixOS/nixos-release-managers

Fix build https://hydra.nixos.org/build/127650244/nixlog/2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Tests relied on a function that has no order guarantee. A fix was merged
to devpi master [1]. We point the package to this commit which should fix
the failing tests on hydra.

[1] devpi/devpi#821
@jfroche
Copy link
Contributor Author

@jfroche jfroche commented Oct 14, 2020

Result of nixpkgs-review pr 100508 1

2 packages built:
  • devpi-client
  • devpi-server

@makefu
Copy link
Contributor

@makefu makefu commented Oct 15, 2020

@GrahamcOfBorg build devpi-server

@makefu
makefu approved these changes Oct 15, 2020
Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 100508 1

2 packages built:
  • devpi-client
  • devpi-server

@jonringer jonringer merged commit 3a57ec4 into NixOS:master Oct 16, 2020
21 of 22 checks passed
21 of 22 checks passed
@github-actions
tests
Details
@github-actions
action
Details
@ofborg
devpi-server on x86_64-darwin
Details
@ofborg
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions
Wait for ofborg
Details
@ofborg
devpi-server on aarch64-linux Success
Details
@ofborg
devpi-server on x86_64-linux Success
Details
@ofborg
devpi-server, devpi-server.passthru.tests on aarch64-linux Success
Details
@ofborg
devpi-server, devpi-server.passthru.tests on x86_64-linux Success
Details
@ofborg
grahamcofborg-eval ^.^!
Details
@ofborg
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="44cb4c4"; rev="44cb4c4baffecef562f2169db3dd106223101f90"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="44cb4c4"; rev="44cb4c4baffecef562f2169db3dd106223101f90"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="44cb4c4"; rev="44cb4c4baffecef562f2169db3dd106223101f90"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="44cb4c4"; rev="44cb4c4baffecef562f2169db3dd106223101f90"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="44cb4c4"; rev="44cb4c4baffecef562f2169db3dd106223101f90"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="44cb4c4"; rev="44cb4c4baffecef562f2169db3dd106223101f90"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="44cb4c4"; rev="44cb4c4baffecef562f2169db3dd106223101f90"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jfroche jfroche mentioned this pull request Oct 16, 2020
3 of 10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants