Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noaa-apt: 1.2.0 -> 1.3.0 #100510

Merged
merged 2 commits into from Oct 29, 2020
Merged

noaa-apt: 1.2.0 -> 1.3.0 #100510

merged 2 commits into from Oct 29, 2020

Conversation

@trepetti
Copy link
Contributor

@trepetti trepetti commented Oct 14, 2020

Motivation for this change

Version bump and making platforms.all explicit to make sure hydra builds binary versions: #99995 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@trepetti
Copy link
Contributor Author

@trepetti trepetti commented Oct 14, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Oct 14, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@trepetti
Copy link
Contributor Author

@trepetti trepetti commented Oct 17, 2020

Result of nixpkgs-review pr 100510 1

1 package built:
  • noaa-apt
Copy link
Contributor

@r-burns r-burns left a comment

Works on darwin too. LGTM

@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Oct 29, 2020

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be put back in the needs_reviewer queue in one day.

@trepetti
Copy link
Contributor Author

@trepetti trepetti commented Oct 29, 2020

/status needs_merger

@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Oct 29, 2020

The PR author cannot set the status to needs_merger. Please wait for an external review.

If you are not the PR author and you are reading this, please review the usage of this bot. You may be able to help. Please make an honest attempt to resolve all outstanding issues before setting to needs_merger.

@r-burns
Copy link
Contributor

@r-burns r-burns commented Oct 29, 2020

Fyi, platforms.all might not be needed for rust packages #101745 (comment). Not really cut and dry though so explicit seems good to be on the safe side.

@r-burns
Copy link
Contributor

@r-burns r-burns commented Oct 29, 2020

/status needs_merger

Copy link
Member

@timokau timokau left a comment

Thanks to both of you!

@timokau timokau merged commit 105d3a7 into NixOS:master Oct 29, 2020
19 checks passed
19 checks passed
@github-actions
tests
Details
@github-actions
action
Details
@ofborg
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions
Wait for ofborg
Details
@ofborg
grahamcofborg-eval ^.^!
Details
@ofborg
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d2529bf"; rev="d2529bf58c4014484d0862e2f67530db30118314"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d2529bf"; rev="d2529bf58c4014484d0862e2f67530db30118314"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d2529bf"; rev="d2529bf58c4014484d0862e2f67530db30118314"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d2529bf"; rev="d2529bf58c4014484d0862e2f67530db30118314"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d2529bf"; rev="d2529bf58c4014484d0862e2f67530db30118314"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d2529bf"; rev="d2529bf58c4014484d0862e2f67530db30118314"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d2529bf"; rev="d2529bf58c4014484d0862e2f67530db30118314"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg
noaa-apt, noaa-apt.passthru.tests on aarch64-linux Success
Details
@ofborg
noaa-apt, noaa-apt.passthru.tests on x86_64-linux Success
Details
@trepetti trepetti deleted the trepetti:noaa-apt-1.3.0 branch Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants