Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mons: 20200107 -> 20200320 #100511

Merged
merged 1 commit into from Nov 19, 2020
Merged

mons: 20200107 -> 20200320 #100511

merged 1 commit into from Nov 19, 2020

Conversation

@thiagokokada
Copy link
Contributor

@thiagokokada thiagokokada commented Oct 14, 2020

Motivation for this change

Make the build simpler now that PR Ventto/mons#36 is merged upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@sarcasticadmin
Copy link
Member

@sarcasticadmin sarcasticadmin commented Oct 24, 2020

Result of nixpkgs-review pr 100511 1

1 package built:
- mons

@sarcasticadmin
Copy link
Member

@sarcasticadmin sarcasticadmin commented Oct 24, 2020

This looks good to me and works for my ubuntu laptop that I tested it with 👍

@thiagokokada
Copy link
Contributor Author

@thiagokokada thiagokokada commented Oct 31, 2020

@mschneiderwng Can we merge it?

@thiagokokada
Copy link
Contributor Author

@thiagokokada thiagokokada commented Nov 7, 2020

/marvin opt-in
/status needs_merger

@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Nov 7, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot added the marvin label Nov 7, 2020
@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Nov 7, 2020

The PR author cannot set the status to needs_merger. Please wait for an external review.

If you are not the PR author and you are reading this, please review the usage of this bot. You may be able to help. Please make an honest attempt to resolve all outstanding issues before setting to needs_merger.

@thiagokokada
Copy link
Contributor Author

@thiagokokada thiagokokada commented Nov 7, 2020

/status needs_reviewer

@kevincox
Copy link
Contributor

@kevincox kevincox commented Nov 19, 2020

Consider taking over maintenance of this package 😉. You can just send that PR directly to me.

@kevincox kevincox merged commit 209796f into NixOS:master Nov 19, 2020
19 checks passed
@thiagokokada thiagokokada deleted the bump-mons branch Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants