Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] pythonPackages.cma: 2.7.0 -> 3.0.3 #100517

Merged
merged 1 commit into from Oct 15, 2020

Conversation

@risicle
Copy link
Contributor

@risicle risicle commented Oct 14, 2020

Motivation for this change

ZHF: #97479

Backport of #87293.

Reverse dependency optuna is already broken.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@bhipple
Copy link
Contributor

@bhipple bhipple commented Oct 15, 2020

Result of nixpkgs-review pr 100517 1

4 packages failed to build:
- python27Packages.cma
- python37Packages.cma
- python37Packages.optuna
- python38Packages.cma

@risicle
Copy link
Contributor Author

@risicle risicle commented Oct 15, 2020

@ofborg build python37Packages.cma python38Packages.cma python27Packages.cma

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

failures are broken on target branch

https://github.com/NixOS/nixpkgs/pull/100517
1 package failed to build:
python37Packages.optuna

3 packages built:
python27Packages.cma python37Packages.cma python38Packages.cma
@jonringer jonringer merged commit 848f952 into NixOS:release-20.09 Oct 15, 2020
20 checks passed
20 checks passed
@github-actions
action
Details
@ofborg
python27Packages.cma, python27Packages.cma.passthru.tests on x86_64-linux Failure
Details
@ofborg
python27Packages.cma, python37Packages.cma, python38Packages.cma on x86_64-linux Failure
Details
@ofborg
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions
Wait for ofborg
Details
@ofborg
grahamcofborg-eval ^.^!
Details
@ofborg
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2b03d8e"; rev="2b03d8e26e1c16aabf2669691172fc81cb028f0e"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2b03d8e"; rev="2b03d8e26e1c16aabf2669691172fc81cb028f0e"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2b03d8e"; rev="2b03d8e26e1c16aabf2669691172fc81cb028f0e"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2b03d8e"; rev="2b03d8e26e1c16aabf2669691172fc81cb028f0e"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2b03d8e"; rev="2b03d8e26e1c16aabf2669691172fc81cb028f0e"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2b03d8e"; rev="2b03d8e26e1c16aabf2669691172fc81cb028f0e"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2b03d8e"; rev="2b03d8e26e1c16aabf2669691172fc81cb028f0e"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg
python27Packages.cma, python27Packages.cma.passthru.tests on aarch64-linux Success
Details
@ofborg
python27Packages.cma, python37Packages.cma, python38Packages.cma on aarch64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants