Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos-install: add passthrough --keep-going flag #100520

Merged
merged 1 commit into from Oct 31, 2020

Conversation

@hyperfekt
Copy link
Contributor

@hyperfekt hyperfekt commented Oct 14, 2020

Motivation for this change

Installs can take a long time and thus are frequently unattended. A small problem occurring should not waste all the time it is unobserved.
Passing a built system to nixos-install is not an option because nix-buildby default will download and build into the installer's store instead of the installee's.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@hyperfekt
Copy link
Contributor Author

@hyperfekt hyperfekt commented Oct 31, 2020

Tested and conflict resolved, ready to merge.
@worldofpeace Can I get you to do this since it's very similar to one you just merged?

@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Oct 31, 2020

Tested and conflict resolved, ready to merge.
@worldofpeace Can I get you to do this since it's very similar to one you just merged?

LGTM. tbh we need a better solution for this

@worldofpeace worldofpeace merged commit eaaf925 into NixOS:master Oct 31, 2020
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants