Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pawn: init at 4.0.5749 #100531

Closed
wants to merge 1 commit into from
Closed

pawn: init at 4.0.5749 #100531

wants to merge 1 commit into from

Conversation

@panurg
Copy link

@panurg panurg commented Oct 14, 2020

Motivation for this change

Just another scripting language and its compiler, VM libraries and some useful tools.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
{
fullName = "An exception clause to explicitly permit static linking of the library to commercial application";
url = "https://www.compuphase.com/pawn/pawn.htm#APACHE_EXCEPTION";
}
Copy link
Member

@roberth roberth Nov 5, 2020

@alyssais, how should this be represented?

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Nov 24, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/384

sha256 = "1qj2n0xql2bmgvng7q7xf7113bgi2kqgaq9jp0dmys3nc3vm123f";
stripRoot = false;
};
buildInputs = with pkgs; [ cmake gcc_multi ];
Copy link
Member

@AndersonTorres AndersonTorres Nov 25, 2020

Why not to declare them on function arguments?

Also, cmake usually goes in nativeBuildInputs.

were essential design criterions for both the language and the abstract
machine.
'';
homepage = https://www.compuphase.com/pawn/pawn.htm;
Copy link
Member

@AndersonTorres AndersonTorres Nov 25, 2020

Put double quotes in the HTTP link strings.

url = "https://www.compuphase.com/${pname}/${pname}-${version}.zip";
sha256 = "1qj2n0xql2bmgvng7q7xf7113bgi2kqgaq9jp0dmys3nc3vm123f";
stripRoot = false;
};
Copy link
Member

@AndersonTorres AndersonTorres Nov 25, 2020

A cosmetic whitespace here, please.

@@ -6539,6 +6539,12 @@
githubId = 1788628;
name = "pandaman";
};
panurg = {
Copy link
Member

@SuperSandro2000 SuperSandro2000 Jan 18, 2021

Please put this into a separate commit with the message maintainers: add panurg.

@@ -0,0 +1,47 @@
{ stdenv, fetchzip, pkgs }:
Copy link
Member

@SuperSandro2000 SuperSandro2000 Jan 18, 2021

Never input pkgs.

cp *.so $out/lib
'';

meta = with stdenv.lib; {
Copy link
Member

@SuperSandro2000 SuperSandro2000 Jan 18, 2021

Suggested change
meta = with stdenv.lib; {
meta = with lib; {

@AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Jan 27, 2021

I have tried it but it does not work.

@stale
Copy link

@stale stale bot commented Jul 27, 2021

I marked this as stale due to inactivity. → More info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants