Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipmiview: 2.16.0 -> 2.17.0 #100534

Closed
wants to merge 2 commits into from
Closed

ipmiview: 2.16.0 -> 2.17.0 #100534

wants to merge 2 commits into from

Conversation

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 15, 2020

Motivation for this change

Noticed the build was broken due to #100532, decided to fix it because I use the tool sometimes.

It had an invalid desktop item category. Also decided to update it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@vlaci
Copy link
Contributor

@vlaci vlaci commented Oct 15, 2020

I'd rather merge #92053 It contains an additional fix for iKVM_ssl.jar which is needed for 2.17

@mweinelt
Copy link
Member Author

@mweinelt mweinelt commented Oct 15, 2020

Sure, I missed that. Thanks for pointing that out.

@mweinelt mweinelt closed this Oct 15, 2020
@mweinelt mweinelt deleted the ipmiview branch Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants