Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corectrl: init at 1.1.1 #100536

Merged
merged 1 commit into from Oct 26, 2020
Merged

corectrl: init at 1.1.1 #100536

merged 1 commit into from Oct 26, 2020

Conversation

@AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Oct 15, 2020

Motivation for this change

Closes #100157

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
}
# TODO: remind upstream that libdrm is not detected at configure time
# TODO: add vulkaninfo and glxinfo to $PATH
# TODO: http://ix.io/2AKo
Copy link
Member Author

@AndersonTorres AndersonTorres Oct 15, 2020

Can someone help me here, please? I have tried to test it, but the application hangs until be C-c'ed.

kf.auth: Tried to start an invalid action: "org.corectrl.helper.init"

http://ix.io/2AKo

Copy link
Contributor

@greizgh greizgh Oct 24, 2020

I gave a quick try and it seems that corectrl attempts to launch a helper on start (this is the dbus action you see).
Eavesdropping on the system bus (dbus-monitor --system), I've seen the following output:
"The name org.corectrl.helper was not provided by any .service files".

Indeed there is no such service on my current system, but the result contains a definition in results/corectrl/share/dbus-1/system-services/org.corectrl.helper.service.

Not sure how to make dbus aware of this, but that's probably the missing part.
Edit: I learnt that dbus are automatically registered for packages in config. Adding corectrl to environment.systemPackages did the trick.

Last issue left is is to launch the helper without running the whole thing as root.

Copy link
Member Author

@AndersonTorres AndersonTorres Oct 26, 2020

So the best way is to make something like a NixOS module, maybe?

Copy link
Member Author

@AndersonTorres AndersonTorres Oct 26, 2020

@greizgh I added vulkanInfo and glxinfo stuff

@greizgh
Copy link
Contributor

@greizgh greizgh commented Oct 25, 2020

@AndersonTorres I just tested this PR and it works great 👍

As mentioned in my previous comment, I had to add corectrl to my systemPackages in order to register the dbus config.

To be able to launch the helper without root, you'll need a running polkit-authentication-agent. That was not my case since I'm not using a full DE.

@AndersonTorres
Copy link
Member Author

@AndersonTorres AndersonTorres commented Oct 26, 2020

For now I will merge it and try to remember making a NixOS service in a future PR.

@AndersonTorres AndersonTorres marked this pull request as ready for review Oct 26, 2020
@AndersonTorres AndersonTorres merged commit ac08a39 into NixOS:master Oct 26, 2020
19 checks passed
19 checks passed
@github-actions[bot]
tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
corectrl, corectrl.passthru.tests on aarch64-linux No attempt
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
corectrl, corectrl.passthru.tests on x86_64-linux Success
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="846266d"; rev="846266d9af5fa0435693f30bca36f80ad1f6d8ad"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="846266d"; rev="846266d9af5fa0435693f30bca36f80ad1f6d8ad"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="846266d"; rev="846266d9af5fa0435693f30bca36f80ad1f6d8ad"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="846266d"; rev="846266d9af5fa0435693f30bca36f80ad1f6d8ad"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="846266d"; rev="846266d9af5fa0435693f30bca36f80ad1f6d8ad"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="846266d"; rev="846266d9af5fa0435693f30bca36f80ad1f6d8ad"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="846266d"; rev="846266d9af5fa0435693f30bca36f80ad1f6d8ad"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@AndersonTorres AndersonTorres deleted the corectrl branch Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants