Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

sonobuoy: 0.16.1 -> 0.19.1 #100537

Merged
merged 2 commits into from Oct 24, 2020
Merged

sonobuoy: 0.16.1 -> 0.19.1 #100537

merged 2 commits into from Oct 24, 2020

Conversation

@wilsonehusin
Copy link
Member

@wilsonehusin wilsonehusin commented Oct 15, 2020

Motivation for this change
  • Updating Sonobuoy to the latest version
    • Sonobuoy adopted Go modules and therefore this needs to be built with buildGoModule
    • Updated repository path as well, referring vmware-tanzu instead of heptio (context captured here)
  • Adding myself to maintainer for this package
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notice to other maintainers

cc: @carlosdagos @saschagrunert

This is my first time contributing to nixpkgs. Happy to assist more to ease this update, though if it's anything of the above I'd like to have some references 馃槂

Copy link
Member

@saschagrunert saschagrunert left a comment

LGTM

@endocrimes
Copy link
Member

@endocrimes endocrimes commented Oct 23, 2020

Result of nixpkgs-review pr 100537 1

1 package built:
  • sonobuoy

Copy link
Member

@endocrimes endocrimes left a comment

Welcome to nixos - LGTM!

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Oct 24, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/261

@marsam marsam merged commit da8c8a2 into NixOS:master Oct 24, 2020
17 checks passed
@marsam
Copy link
Contributor

@marsam marsam commented Oct 24, 2020

Thank you for your contribution, and hope to see you again soon!

@wilsonehusin wilsonehusin deleted the sonobuoy-0.19 branch Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants