Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodePackages.cdk8s-cli: init at 1.0.0-beta.5 #100540

Closed

Conversation

@ndarwincorn
Copy link
Contributor

@ndarwincorn ndarwincorn commented Oct 15, 2020

Motivation for this change

This adds cdk8s-cli using generate.sh

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 27, 2020

@ndarwincorn can you please rebase this? Hit me up on IRC to let me merge it before it conflicts again.

@ndarwincorn ndarwincorn force-pushed the add-cdk8s-cli-node-package branch from 9aaf00a to abb4f97 Dec 17, 2020
@ndarwincorn ndarwincorn changed the title nodePackages.cdk8s-cli: init at 0.3.0 nodePackages.cdk8s-cli: init at 1.0.0-beta.5 Dec 17, 2020
@ndarwincorn
Copy link
Contributor Author

@ndarwincorn ndarwincorn commented Dec 17, 2020

@SuperSandro2000 - I've rebased this. I'll ping you on IRC

@ndarwincorn ndarwincorn force-pushed the add-cdk8s-cli-node-package branch from abb4f97 to 360beaa Jan 1, 2021
@ndarwincorn ndarwincorn force-pushed the add-cdk8s-cli-node-package branch from 360beaa to a581279 Jan 1, 2021
@ofborg ofborg bot requested a review from midchildan Jan 1, 2021
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Jan 2, 2021

I am probably fixing the merge conflict that will be here shortly in another PR and closing this one.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Jan 2, 2021

PR got combined with a few other node updates. Closing so that the update goes trough smoothly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants