Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] python3Packages.google_cloud_asset: fix build, 2.0.0 -> 2.1.0 #100546

Merged

Conversation

@austinbutler
Copy link
Contributor

@austinbutler austinbutler commented Oct 15, 2020

Motivation for this change

Backport of: #100009

ZHF: #97479
https://hydra.nixos.org/build/127625743

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 100546 1

10 packages built:
  • python37Packages.google-cloud-access-context-manager
  • python37Packages.google-cloud-org-policy
  • python37Packages.google_cloud_asset
  • python37Packages.google_cloud_dataproc
  • python37Packages.libcst
  • python38Packages.google-cloud-access-context-manager
  • python38Packages.google-cloud-org-policy
  • python38Packages.google_cloud_asset
  • python38Packages.google_cloud_dataproc
  • python38Packages.libcst

@jonringer jonringer merged commit 2450fe8 into NixOS:release-20.09 Oct 15, 2020
16 checks passed
16 checks passed
@github-actions[bot]
action
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cbe1349"; rev="cbe1349fa71bc6e0964604ad635b9cf974b9031a"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cbe1349"; rev="cbe1349fa71bc6e0964604ad635b9cf974b9031a"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cbe1349"; rev="cbe1349fa71bc6e0964604ad635b9cf974b9031a"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cbe1349"; rev="cbe1349fa71bc6e0964604ad635b9cf974b9031a"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cbe1349"; rev="cbe1349fa71bc6e0964604ad635b9cf974b9031a"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cbe1349"; rev="cbe1349fa71bc6e0964604ad635b9cf974b9031a"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cbe1349"; rev="cbe1349fa71bc6e0964604ad635b9cf974b9031a"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@austinbutler austinbutler deleted the google_cloud_asset-backport branch Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants