Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix: build with default stdenv #100558

Merged
merged 1 commit into from Oct 15, 2020
Merged

Conversation

@thefloweringash
Copy link
Member

@thefloweringash thefloweringash commented Oct 15, 2020

This was required for Nix v2.2.2 which did not build with
libcxx 7. This is no longer required for any current version of Nix.

Motivation for this change

Tidy-up. This removes a usage of llvm_6 and decreases the dependencies of Nix on darwin, which uses an llvm_7 stdenv by default.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
This was required for Nix v2.2.2 which did not build with
libcxx 7. This is no longer required for any current version of Nix.
@ofborg ofborg bot requested a review from edolstra Oct 15, 2020
@edolstra edolstra merged commit ee81376 into NixOS:master Oct 15, 2020
19 checks passed
@thefloweringash thefloweringash deleted the nix-default-stdenv branch Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants