Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zoom-us: add xdg_utils to PATH #100560

Closed
wants to merge 1 commit into from
Closed

Conversation

@xfix
Copy link
Contributor

@xfix xfix commented Oct 15, 2020

This allows Zoom to open a web browser other than Google Chrome,
Firefox or Opera when xdg_utils is not installed.

Motivation for this change

It may help with https://discourse.nixos.org/t/no-sso-in-zoom-unless-firefox-is-installed/9453.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Oct 15, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/no-sso-in-zoom-unless-firefox-is-installed/9453/2

This allows Zoom to open a web browser other than Google Chrome,
Firefox or Opera when xdg_utils is not installed.
@xfix xfix force-pushed the zoom-us-add-xdg-utils-to-path branch from e6310c8 to d4f987f Oct 15, 2020
@xfix xfix changed the title zoom_us: add xdg_utils to PATH zoom-us: add xdg_utils to PATH Oct 15, 2020
@ofborg ofborg bot requested review from doronbehar, danbst and tadfisher Oct 15, 2020
jktjkt
jktjkt approved these changes Oct 15, 2020
@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Oct 15, 2020

It may help with https://discourse.nixos.org/t/no-sso-in-zoom-unless-firefox-is-installed/9453

So we are not sure if it fixes the issue?

@xfix
Copy link
Contributor Author

@xfix xfix commented Oct 15, 2020

It may help with https://discourse.nixos.org/t/no-sso-in-zoom-unless-firefox-is-installed/9453

So we are not sure if it fixes the issue?

Honestly, I have no idea, I don't use zoom myself. I'm doing this because https://github.com/qt/qtbase/blob/871392790eafdd22521367ba485da5c10e9bb0db/src/gui/platform/unix/qgenericunixservices.cpp#L126 suggests it may help. Qt tries xdg-open first before it uses really weird fallback code.

The error message "Unable to detect a web browser to launch" comes from Qt according to web search.

Copy link
Contributor

@tadfisher tadfisher left a comment

It can't hurt anything, and it does appear Qt is indeed shelling out to xdg-open for this interaction. This may explain the SSO/Google login issues, as I have xdg-open in my $PATH but other users may not.

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Oct 21, 2020

It can't hurt anything, and it does appear Qt is indeed shelling out to xdg-open for this interaction. This may explain the SSO/Google login issues, as I have xdg-open in my $PATH but other users may not.

I would have tested that myself, but I don't have a way to sign in with SSO to reproduce the behavior. OTH, if someone else has SSO, uninstalling xdg_utils for the sake of testing this shouldn't be difficult.

@SuperSandro2000 SuperSandro2000 marked this pull request as draft Nov 27, 2020
@xfix xfix closed this Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants