Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.optparse-applicative: Fix for compgen error #100563

Conversation

@roberth
Copy link
Member

@roberth roberth commented Oct 15, 2020

Motivation for this change

Rebase; closes #100515

Fix optparse-applicative's call to bash when running in a nix-shell. Although nix-shell invokes bashInteractive, it has a non-interactive bash on PATH most of the time, because that's what stdenv uses. optparse-applicative can get a better bash via $SHELL, fixing the error:

[nix-shell]$ mycommand --file <TAB>bash: compgen: command not found
bash: compgen: command not found
bash: compgen: command not found
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@cdepillabout
Copy link
Member

@cdepillabout cdepillabout commented Oct 15, 2020

Looks good, builds for me. Thanks!

@cdepillabout cdepillabout merged commit b18f75c into NixOS:haskell-updates Oct 15, 2020
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants