Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscx/ms-vsliveshare-vsliveshare: Init at 1.0.2902 #100583

Merged
merged 1 commit into from Oct 16, 2020

Conversation

@jraygauthier
Copy link
Member

@jraygauthier jraygauthier commented Oct 15, 2020

Motivation for this change

This vscode extension is based in some binaries that needs to be patched (elf) (won't work on nixos othewise).

#41189

Seems to be needed by quite a lot of people.

Might require some heavy level of maintenance over time.

However, as a lot of people depends on this (and this is already base on the work of others), I assume I won't be the sole maintainer of the package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Tested in isolation via the following expression:

$ cd /path/to/my/nixpkgs
$ nix-build -I nixpkgs=. -E 'with import <nixpkgs> {config={allowUnfree = true;};}; vscode-with-extensions.override {vscodeExtensions = with vscode-extensions; [ms-vsliveshare.vsliveshare];}'

Used 2 such local instances of vscode with liveshare and validated that interaction is possible. Tested various commands (from this particular extension) from the command palette successfully.

Copy link
Member

@Flakebi Flakebi left a comment

Nice, it works!
I built with the command you gave, started a live share session, invited some people and everything just worked.

@jraygauthier
Copy link
Member Author

@jraygauthier jraygauthier commented Oct 15, 2020

Excellent @Flakebi, happy to hear this. Thanks for the test :).

@aaronjanse
Copy link
Member

@aaronjanse aaronjanse commented Oct 15, 2020

I built with the command you gave, started a live share session, invited some people and everything just worked.

Same here! It was quite pleasant!

Thank you @jraygauthier for the PR and @msteen for the code it's based on.

@teto teto merged commit 8b4db57 into NixOS:master Oct 16, 2020
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants