Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make-desktopitem: name was being used instead of desktopName #100591

Merged
merged 1 commit into from Oct 18, 2020

Conversation

@LogicalOverflow
Copy link
Contributor

@LogicalOverflow LogicalOverflow commented Oct 15, 2020

Motivation for this change

Name should be used as filename and desktopName for the name attribute of the desktop entry (according to docs). Looking through the history, this was changed in 51cc553.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Name should be used as filename and desktopName for the name attribute of the desktop entry (according to docs).
@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 18, 2020

@piegamesde
Copy link
Member

@piegamesde piegamesde commented Oct 18, 2020

The fact that this one slipped even though we stared at the original change that much is a bit embarrassing.

@maralorn
Copy link
Member

@maralorn maralorn commented Oct 18, 2020

Oh, wow. Sorry about that. I hadn‘t thought of that failure mode …

@maralorn maralorn merged commit 4d9adee into NixOS:master Oct 18, 2020
17 checks passed
@maralorn
Copy link
Member

@maralorn maralorn commented Oct 18, 2020

Thank you for that quick fix!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants