Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pyelftools: disable tests on Darwin #100602

Merged
merged 1 commit into from Nov 6, 2020

Conversation

@siriobalmelli
Copy link
Contributor

@siriobalmelli siriobalmelli commented Oct 15, 2020

af27072 broke the build on Darwin (see #99202)

There does not seem to be any way to sanely enable tests on Darwin.

Tests initially fail because of missing 'greadelf'
expected by test/run_readelf_tests.py.

This is fixed by:

  • adding 'binutils-unwrapped' to checkInputs
  • hardlinking 'readelf' to 'greadelf' in a temp bin dir
  • exporting temp bin dir to PATH

This leads to further test failures because of 'readelf' version mismatch
causing output inconsistencies.

See test/run_readelf_tests.py:31 for further details.

Signed-off-by: Sirio Balmelli sirio@b-ad.ch

Motivation for this change

build on Darwin

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

@Pamplemousse Pamplemousse left a comment

LGTM 👍
Builds properly on NixOS.

@siriobalmelli siriobalmelli force-pushed the fix/pyelftools branch 2 times, most recently from e6b499c to 3910fe4 Oct 28, 2020
@ofborg ofborg bot requested a review from Pamplemousse Oct 28, 2020
@ofborg ofborg bot requested a review from Pamplemousse Nov 2, 2020
igsha
igsha approved these changes Nov 3, 2020
Copy link
Contributor

@igsha igsha left a comment

LGTM

af27072 broke the build on Darwin.

There does not seem to be any way to sanely enable tests on Darwin.

Tests initially fail because of missing 'greadelf'
expected by test/run_readelf_tests.py.

This is fixed by:

- adding 'binutils-unwrapped' to checkInputs
- hardlinking 'readelf' to 'greadelf' in a temp bin dir
- exporting temp bin dir to PATH

This leads to further test failures because of 'readelf' version mismatch
causing output inconsistencies.

See test/run_readelf_tests.py:31 for further details.

Signed-off-by: Sirio Balmelli <sirio@b-ad.ch>
@ofborg ofborg bot requested review from igsha and Pamplemousse Nov 6, 2020
igsha
igsha approved these changes Nov 6, 2020
Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 100602 1

@jonringer jonringer merged commit 8fb56a4 into NixOS:master Nov 6, 2020
17 checks passed
@siriobalmelli siriobalmelli deleted the fix/pyelftools branch Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants