Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qutebrowser: 1.13.1 -> 1.14.0 #100608

Merged
merged 1 commit into from Oct 15, 2020
Merged

qutebrowser: 1.13.1 -> 1.14.0 #100608

merged 1 commit into from Oct 15, 2020

Conversation

@chvp
Copy link
Member

@chvp chvp commented Oct 15, 2020

Motivation for this change

Update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

I tested it briefly and looks ok. You should only fix the typo in the commit message.

@chvp chvp changed the title qutebrowser: 1.31.1 -> 1.14.0 qutebrowser: 1.13.1 -> 1.14.0 Oct 15, 2020
@chvp chvp force-pushed the qutebrowser-1.14.0 branch from 2099cf5 to 0ff5728 Oct 15, 2020
@chvp
Copy link
Member Author

@chvp chvp commented Oct 15, 2020

I tested it briefly and looks ok. You should only fix the typo in the commit message.

Fixed. Sorry about that.

@ofborg ofborg bot requested a review from rnhmjoj Oct 15, 2020
@rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Oct 15, 2020

I'm looking into the screen sharing support on wayland. The changelog says it should only be necessary to pull libpipewire in but I'm not sure the feature is enabled in QtWebEngine.

@magnetophon
Copy link
Member

@magnetophon magnetophon commented Oct 15, 2020

I'm running this right now, works perfectly.

@rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Oct 15, 2020

Uhm, I tried using this configuration but screen sharing doesn't even work in chromium. Probably someone more wise in wayland-lore should do this.

@rnhmjoj rnhmjoj merged commit 1bfa8c1 into NixOS:master Oct 15, 2020
19 checks passed
@chvp chvp deleted the qutebrowser-1.14.0 branch Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants