Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtk3: 3.24.21 -> 3.24.23 #100621

Closed
wants to merge 2 commits into from
Closed

gtk3: 3.24.21 -> 3.24.23 #100621

wants to merge 2 commits into from

Conversation

@pickfire
Copy link
Contributor

@pickfire pickfire commented Oct 15, 2020

Motivation for this change

I got build errors when packaging lxsession, maybe it needs a newer gtk3? Still building on my side so I just send a patch first.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@7c6f434c
Copy link
Member

@7c6f434c 7c6f434c commented Oct 19, 2020

Does this miss the hash update? And I guess it is large enough to go to staging?

@pickfire
Copy link
Contributor Author

@pickfire pickfire commented Oct 19, 2020

Does this miss the hash update? And I guess it is large enough to go to staging?

Hash update? Not sure what do you mean. Maybe large enough?

@7c6f434c
Copy link
Member

@7c6f434c 7c6f434c commented Oct 19, 2020

@pickfire
Copy link
Contributor Author

@pickfire pickfire commented Oct 19, 2020

Ah, I believe I did missed the hash update but how come the CI still passes?

@7c6f434c
Copy link
Member

@7c6f434c 7c6f434c commented Oct 19, 2020

Well, build failures are different, and red status should be a definite «never merge», so build failures are neutral and need to be evaluated by humans.

If you click through to the «Details» of builds, you will see a build failure.

@pickfire
Copy link
Contributor Author

@pickfire pickfire commented Oct 20, 2020

  wanted: sha256-rupq58016D38dpm+cWUZ+u/KNGxi54TdGjfZ35TAj1I=
  got:    sha256-XYZNJINXoiUVRbM4ezWULeX2bkxmAT8JYutctvja4rE=

error output not helpful, I need to run nix-prefetch-url to know what is it.

@7c6f434c
Copy link
Member

@7c6f434c 7c6f434c commented Oct 20, 2020

@pickfire
Copy link
Contributor Author

@pickfire pickfire commented Oct 20, 2020

Updated

@7c6f434c
Copy link
Member

@7c6f434c 7c6f434c commented Oct 21, 2020

@ofborg eval

@7c6f434c
Copy link
Member

@7c6f434c 7c6f434c commented Oct 21, 2020

Please retarget to staging

@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Oct 21, 2020

This is also part of #98316 (6426754). We might want to fast-track it by cherry-picking to staging.

Changes:

@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Oct 21, 2020

Also I would not expect lxsession being last released in February to depend on GTK released in August or September.

@pickfire
Copy link
Contributor Author

@pickfire pickfire commented Oct 22, 2020

It is not the lxsession that we already have, I am trying to package LXDE so this one may depend of gtk2 or gtk3 unlike the current one which only depends on gtk3 IIRC.

@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Oct 22, 2020

Why would it make sense to depend on a library that has been deprecated for years now? Each configuration flag introduced to nixpkgs increases its complexity so it should be carefully weighted against the benefit it would bring.

@pickfire
Copy link
Contributor Author

@pickfire pickfire commented Oct 23, 2020

Because the gtk3 support is said to still have bugs, gtk2 is more stable.

@FRidh
Copy link
Member

@FRidh FRidh commented Nov 18, 2020

Closing because #98316 got merged.

@FRidh FRidh closed this Nov 18, 2020
@pickfire pickfire deleted the patch-1 branch Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants