Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clipcat: init at 0.4.19 #100638

Merged
merged 1 commit into from Oct 29, 2020
Merged

clipcat: init at 0.4.19 #100638

merged 1 commit into from Oct 29, 2020

Conversation

@xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Oct 15, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@xrelkd
Copy link
Contributor Author

@xrelkd xrelkd commented Oct 18, 2020

Hi @marsam, Could you review this PR? Thank you!!

installShellCompletion --bash --name clipcat-notify completions/bash-completion/completions/clipcat-notify
installShellCompletion --fish --name clipcat-notify.fish completions/fish/completions/clipcat-notify.fish
installShellCompletion --zsh --name _clipcat-notify completions/zsh/site-functions/_clipcat-notify

This comment has been minimized.

@marsam

marsam Oct 29, 2020
Contributor

I think you can use glob here:

installShellCompletion --bash completions/bash-completion/completions/*
installShellCompletion --fish completions/fish/completions/*
installShellCompletion --zsh completions/zsh/site-functions/*

not blocking for merge though

@marsam
Copy link
Contributor

@marsam marsam commented Oct 29, 2020

Sorry for the delay. LGTM

@marsam marsam merged commit 8305cce into NixOS:master Oct 29, 2020
19 of 20 checks passed
19 of 20 checks passed
@github-actions
tests
Details
@github-actions
action
Details
@ofborg
clipcat, clipcat.passthru.tests on x86_64-darwin
Details
@ofborg
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions
Wait for ofborg
Details
@ofborg
clipcat, clipcat.passthru.tests on aarch64-linux Success
Details
@ofborg
clipcat, clipcat.passthru.tests on x86_64-linux Success
Details
@ofborg
grahamcofborg-eval ^.^!
Details
@ofborg
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7ee6eb7"; rev="7ee6eb7e1d81951d8fa8fda23a7d3e097b845de1"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7ee6eb7"; rev="7ee6eb7e1d81951d8fa8fda23a7d3e097b845de1"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7ee6eb7"; rev="7ee6eb7e1d81951d8fa8fda23a7d3e097b845de1"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7ee6eb7"; rev="7ee6eb7e1d81951d8fa8fda23a7d3e097b845de1"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7ee6eb7"; rev="7ee6eb7e1d81951d8fa8fda23a7d3e097b845de1"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7ee6eb7"; rev="7ee6eb7e1d81951d8fa8fda23a7d3e097b845de1"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7ee6eb7"; rev="7ee6eb7e1d81951d8fa8fda23a7d3e097b845de1"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@xrelkd
Copy link
Contributor Author

@xrelkd xrelkd commented Oct 29, 2020

@marsam Thank you very much!!

@xrelkd xrelkd deleted the xrelkd:add/clipcat branch Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants