Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

astroid: fix python plugin usage #100642

Merged
merged 1 commit into from Jan 13, 2021
Merged

Conversation

@oxzi
Copy link
Member

@oxzi oxzi commented Oct 15, 2020

Motivation for this change

Astroid's python-based plugin system was not usable before.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@oxzi oxzi requested review from bdimcheff and SuprDewd Oct 19, 2020
Copy link
Contributor

@SuprDewd SuprDewd left a comment

LGTM

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Please fix the eval error.

@oxzi oxzi force-pushed the oxzi:astroid-plugin-fix branch from 4f6b64a to 85eef75 Jan 8, 2021
@oxzi oxzi requested a review from SuperSandro2000 Jan 8, 2021
@ofborg ofborg bot requested a review from SuprDewd Jan 8, 2021
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Jan 11, 2021

@oxzi please fix the merge conflict.

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@oxzi oxzi force-pushed the oxzi:astroid-plugin-fix branch from f17b3a7 to 1eae217 Jan 12, 2021
@oxzi oxzi requested a review from SuperSandro2000 Jan 12, 2021
@oxzi
Copy link
Member Author

@oxzi oxzi commented Jan 12, 2021

@SuperSandro2000: Thanks, please have another look.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Jan 13, 2021

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 100642 run on x86_64-linux 1

1 package built:
  • astroid

@SuperSandro2000 SuperSandro2000 merged commit c7a1cbf into NixOS:master Jan 13, 2021
19 checks passed
19 checks passed
@github-actions
tests
Details
@github-actions
action
Details
@ofborg
astroid, astroid.passthru.tests on x86_64-linux Failure
Details
@ofborg
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions
Wait for ofborg
Details
@ofborg
astroid, astroid.passthru.tests on aarch64-linux Success
Details
@ofborg
grahamcofborg-eval ^.^!
Details
@ofborg
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1eae217"; rev="1eae217a5ff2fb9738d56d5769a518e0086ff7ec"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1eae217"; rev="1eae217a5ff2fb9738d56d5769a518e0086ff7ec"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1eae217"; rev="1eae217a5ff2fb9738d56d5769a518e0086ff7ec"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1eae217"; rev="1eae217a5ff2fb9738d56d5769a518e0086ff7ec"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1eae217"; rev="1eae217a5ff2fb9738d56d5769a518e0086ff7ec"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1eae217"; rev="1eae217a5ff2fb9738d56d5769a518e0086ff7ec"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1eae217"; rev="1eae217a5ff2fb9738d56d5769a518e0086ff7ec"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@oxzi oxzi deleted the oxzi:astroid-plugin-fix branch Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants