Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux_zen: 5.8.13 -> 5.9.3 #100645

Merged
merged 2 commits into from Nov 3, 2020
Merged

linux_zen: 5.8.13 -> 5.9.3 #100645

merged 2 commits into from Nov 3, 2020

Conversation

@andresilva
Copy link
Member

@andresilva andresilva commented Oct 15, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

@Atemu Atemu left a comment

Tag is 5.9, not 5.9.0

@@ -1,7 +1,7 @@
{ stdenv, fetchFromGitHub, buildLinux, ... } @ args:

let
version = "5.8.13";
version = "5.9.0";
Copy link
Member

@Atemu Atemu Oct 16, 2020

Tag is 5.9, not 5.9.0

Copy link
Member Author

@andresilva andresilva Oct 16, 2020

If I set it to 5.9 it fails to build since modDirVersion doesn't match.

Copy link
Member Author

@andresilva andresilva Oct 16, 2020

I can separate them into different variables I guess. I had set it to 5.9 initially until I found this.

Copy link
Member

@Atemu Atemu Oct 17, 2020

What I did was to just append .0 in modDirVersion (and add a comment).

Perhaps we should make the kernel build able to handle major.minor though.

@andresilva andresilva changed the title linux_zen: 5.8.13 -> 5.9.0 linux_zen: 5.8.13 -> 5.9.1 Oct 17, 2020
@andresilva
Copy link
Member Author

@andresilva andresilva commented Oct 17, 2020

@Atemu In the meantime 5.9.1 was released and I decided to update this PR, hope that's ok. Our future selves can deal with the issue of .0 releases :)

@ofborg ofborg bot requested a review from Atemu Oct 17, 2020
@andresilva
Copy link
Member Author

@andresilva andresilva commented Oct 21, 2020

@Atemu Do you mind if I add myself as maintainer?

@Atemu
Copy link
Member

@Atemu Atemu commented Oct 21, 2020

Not at all :)

Copy link
Member

@Atemu Atemu left a comment

Result of nixpkgs-review pr 100645 1

30 packages failed to build:
  • linuxPackages_zen.amdgpu-pro
  • linuxPackages_zen.anbox
  • linuxPackages_zen.broadcom_sta
  • linuxPackages_zen.chipsec
  • linuxPackages_zen.cryptodev
  • linuxPackages_zen.dpdk
  • linuxPackages_zen.ena
  • linuxPackages_zen.evdi
  • linuxPackages_zen.ixgbevf
  • linuxPackages_zen.lttng-modules
  • linuxPackages_zen.mwprocapture
  • linuxPackages_zen.mxu11x0
  • linuxPackages_zen.ndiswrapper
  • linuxPackages_zen.nvidia_x11_legacy304
  • linuxPackages_zen.nvidia_x11_legacy340
  • linuxPackages_zen.nvidia_x11_legacy390
  • linuxPackages_zen.nvidia_x11_vulkan_beta
  • linuxPackages_zen.openafs
  • linuxPackages_zen.openafs_1_8
  • linuxPackages_zen.phc-intel
  • linuxPackages_zen.r8168
  • linuxPackages_zen.rtl8723bs
  • linuxPackages_zen.rtl8814au
  • linuxPackages_zen.rtl8821au
  • linuxPackages_zen.rtl88xxau-aircrack
  • linuxPackages_zen.rtlwifi_new
  • linuxPackages_zen.sch_cake
  • linuxPackages_zen.tbs
  • linuxPackages_zen.virtualbox
  • linuxPackages_zen.virtualboxGuestAdditions
49 packages built:
  • linuxPackages_zen.acpi_call
  • linuxPackages_zen.asus-wmi-sensors
  • linuxPackages_zen.batman_adv
  • linuxPackages_zen.bbswitch
  • linuxPackages_zen.bcc
  • linuxPackages_zen.bpftrace
  • linuxPackages_zen.can-isotp
  • linuxPackages_zen.cpupower
  • linuxPackages_zen.ddcci-driver
  • linuxPackages_zen.digimend
  • linuxPackages_zen.facetimehd
  • linuxPackages_zen.fwts-efi-runtime
  • linuxPackages_zen.hyperv-daemons
  • linuxPackages_zen.intel-speed-select
  • linuxPackages_zen.it87
  • linuxPackages_zen.jool
  • linux_zen (linuxPackages_zen.kernel)
  • linuxPackages_zen.mba6x_bl
  • linuxPackages_zen.netatop
  • linuxPackages_zen.nvidia_x11 (linuxPackages_zen.nvidia_x11_beta)
  • linuxPackages_zen.nvidiabl
  • linuxPackages_zen.oci-seccomp-bpf-hook
  • linuxPackages_zen.openrazer
  • linuxPackages_zen.perf
  • linuxPackages_zen.ply
  • linuxPackages_zen.r8125
  • linuxPackages_zen.rtl8192eu
  • linuxPackages_zen.rtl8812au
  • linuxPackages_zen.rtl8821ce
  • linuxPackages_zen.rtl8821cu
  • linuxPackages_zen.rtl88x2bu
  • linuxPackages_zen.sysdig
  • linuxPackages_zen.system76
  • linuxPackages_zen.system76-acpi
  • linuxPackages_zen.system76-io
  • linuxPackages_zen.systemtap
  • linuxPackages_zen.tmon
  • linuxPackages_zen.tp_smapi
  • linuxPackages_zen.turbostat
  • linuxPackages_zen.tuxedo-keyboard
  • linuxPackages_zen.usbip
  • linuxPackages_zen.v4l2loopback
  • linuxPackages_zen.v86d
  • linuxPackages_zen.vhba
  • linuxPackages_zen.x86_energy_perf_policy
  • linuxPackages_zen.xpadneo
  • linuxPackages_zen.zenpower
  • linuxPackages_zen.zfs (linuxPackages_zen.zfsStable)
  • linuxPackages_zen.zfsUnstable

Fsync does not work.

pkgs/os-specific/linux/kernel/linux-zen.nix Show resolved Hide resolved
pkgs/os-specific/linux/kernel/linux-zen.nix Show resolved Hide resolved
@ofborg ofborg bot requested a review from Atemu Oct 25, 2020
@andresilva
Copy link
Member Author

@andresilva andresilva commented Oct 27, 2020

Result of nixpkgs-review pr 100645 1

8 packages marked as broken and skipped:
  • linuxPackages_zen.ixgbevf
  • linuxPackages_zen.lttng-modules
  • linuxPackages_zen.nvidia_x11_legacy304
  • linuxPackages_zen.openafs
  • linuxPackages_zen.phc-intel
  • linuxPackages_zen.rtl8723bs
  • linuxPackages_zen.sch_cake
  • linuxPackages_zen.tbs
20 packages failed to build:
  • linuxPackages_zen.amdgpu-pro
  • linuxPackages_zen.anbox
  • linuxPackages_zen.broadcom_sta
  • linuxPackages_zen.chipsec
  • linuxPackages_zen.cryptodev
  • linuxPackages_zen.dpdk
  • linuxPackages_zen.ena
  • linuxPackages_zen.evdi
  • linuxPackages_zen.mwprocapture
  • linuxPackages_zen.mxu11x0
  • linuxPackages_zen.ndiswrapper
  • linuxPackages_zen.nvidia_x11_legacy340
  • linuxPackages_zen.nvidia_x11_legacy390
  • linuxPackages_zen.nvidia_x11_vulkan_beta
  • linuxPackages_zen.openafs_1_8
  • linuxPackages_zen.r8168
  • linuxPackages_zen.rtl8814au
  • linuxPackages_zen.rtl8821au
  • linuxPackages_zen.rtl88xxau-aircrack
  • linuxPackages_zen.rtlwifi_new
51 packages built:
  • linuxPackages_zen.acpi_call
  • linuxPackages_zen.asus-wmi-sensors
  • linuxPackages_zen.batman_adv
  • linuxPackages_zen.bbswitch
  • linuxPackages_zen.bcc
  • linuxPackages_zen.bpftrace
  • linuxPackages_zen.can-isotp
  • linuxPackages_zen.cpupower
  • linuxPackages_zen.ddcci-driver
  • linuxPackages_zen.digimend
  • linuxPackages_zen.facetimehd
  • linuxPackages_zen.fwts-efi-runtime
  • linuxPackages_zen.hyperv-daemons
  • linuxPackages_zen.intel-speed-select
  • linuxPackages_zen.it87
  • linuxPackages_zen.jool
  • linux_zen (linuxPackages_zen.kernel)
  • linuxPackages_zen.mba6x_bl
  • linuxPackages_zen.netatop
  • linuxPackages_zen.nvidia_x11 (linuxPackages_zen.nvidia_x11_beta)
  • linuxPackages_zen.nvidiabl
  • linuxPackages_zen.oci-seccomp-bpf-hook
  • linuxPackages_zen.openrazer
  • linuxPackages_zen.perf
  • linuxPackages_zen.ply
  • linuxPackages_zen.r8125
  • linuxPackages_zen.rtl8192eu
  • linuxPackages_zen.rtl8812au
  • linuxPackages_zen.rtl8821ce
  • linuxPackages_zen.rtl8821cu
  • linuxPackages_zen.rtl88x2bu
  • linuxPackages_zen.sysdig
  • linuxPackages_zen.system76
  • linuxPackages_zen.system76-acpi
  • linuxPackages_zen.system76-io
  • linuxPackages_zen.systemtap
  • linuxPackages_zen.tmon
  • linuxPackages_zen.tp_smapi
  • linuxPackages_zen.turbostat
  • linuxPackages_zen.tuxedo-keyboard
  • linuxPackages_zen.usbip
  • linuxPackages_zen.v4l2loopback
  • linuxPackages_zen.v86d
  • linuxPackages_zen.vhba
  • linuxPackages_zen.virtualbox
  • linuxPackages_zen.virtualboxGuestAdditions
  • linuxPackages_zen.x86_energy_perf_policy
  • linuxPackages_zen.xpadneo
  • linuxPackages_zen.zenpower
  • linuxPackages_zen.zfs (linuxPackages_zen.zfsStable)
  • linuxPackages_zen.zfsUnstable

Atemu
Atemu approved these changes Oct 28, 2020
Copy link
Member

@Atemu Atemu left a comment

Result of nixpkgs-review pr 100645 1

8 packages marked as broken and skipped:
  • linuxPackages_zen.ixgbevf
  • linuxPackages_zen.lttng-modules
  • linuxPackages_zen.nvidia_x11_legacy304
  • linuxPackages_zen.openafs
  • linuxPackages_zen.phc-intel
  • linuxPackages_zen.rtl8723bs
  • linuxPackages_zen.sch_cake
  • linuxPackages_zen.tbs
20 packages failed to build:
  • linuxPackages_zen.amdgpu-pro
  • linuxPackages_zen.anbox
  • linuxPackages_zen.broadcom_sta
  • linuxPackages_zen.chipsec
  • linuxPackages_zen.cryptodev
  • linuxPackages_zen.dpdk
  • linuxPackages_zen.ena
  • linuxPackages_zen.evdi
  • linuxPackages_zen.mwprocapture
  • linuxPackages_zen.mxu11x0
  • linuxPackages_zen.ndiswrapper
  • linuxPackages_zen.nvidia_x11_legacy340
  • linuxPackages_zen.nvidia_x11_legacy390
  • linuxPackages_zen.nvidia_x11_vulkan_beta
  • linuxPackages_zen.openafs_1_8
  • linuxPackages_zen.r8168
  • linuxPackages_zen.rtl8814au
  • linuxPackages_zen.rtl8821au
  • linuxPackages_zen.rtl88xxau-aircrack
  • linuxPackages_zen.rtlwifi_new
51 packages built:
  • linuxPackages_zen.acpi_call
  • linuxPackages_zen.asus-wmi-sensors
  • linuxPackages_zen.batman_adv
  • linuxPackages_zen.bbswitch
  • linuxPackages_zen.bcc
  • linuxPackages_zen.bpftrace
  • linuxPackages_zen.can-isotp
  • linuxPackages_zen.cpupower
  • linuxPackages_zen.ddcci-driver
  • linuxPackages_zen.digimend
  • linuxPackages_zen.facetimehd
  • linuxPackages_zen.fwts-efi-runtime
  • linuxPackages_zen.hyperv-daemons
  • linuxPackages_zen.intel-speed-select
  • linuxPackages_zen.it87
  • linuxPackages_zen.jool
  • linux_zen (linuxPackages_zen.kernel)
  • linuxPackages_zen.mba6x_bl
  • linuxPackages_zen.netatop
  • linuxPackages_zen.nvidia_x11 (linuxPackages_zen.nvidia_x11_beta)
  • linuxPackages_zen.nvidiabl
  • linuxPackages_zen.oci-seccomp-bpf-hook
  • linuxPackages_zen.openrazer
  • linuxPackages_zen.perf
  • linuxPackages_zen.ply
  • linuxPackages_zen.r8125
  • linuxPackages_zen.rtl8192eu
  • linuxPackages_zen.rtl8812au
  • linuxPackages_zen.rtl8821ce
  • linuxPackages_zen.rtl8821cu
  • linuxPackages_zen.rtl88x2bu
  • linuxPackages_zen.sysdig
  • linuxPackages_zen.system76
  • linuxPackages_zen.system76-acpi
  • linuxPackages_zen.system76-io
  • linuxPackages_zen.systemtap
  • linuxPackages_zen.tmon
  • linuxPackages_zen.tp_smapi
  • linuxPackages_zen.turbostat
  • linuxPackages_zen.tuxedo-keyboard
  • linuxPackages_zen.usbip
  • linuxPackages_zen.v4l2loopback
  • linuxPackages_zen.v86d
  • linuxPackages_zen.vhba
  • linuxPackages_zen.virtualbox
  • linuxPackages_zen.virtualboxGuestAdditions
  • linuxPackages_zen.x86_energy_perf_policy
  • linuxPackages_zen.xpadneo
  • linuxPackages_zen.zenpower
  • linuxPackages_zen.zfs (linuxPackages_zen.zfsStable)
  • linuxPackages_zen.zfsUnstable

Didn't test this precise version but 5.9.1-zen2 works on my machine with ZFS and Nvidia.

@Atemu
Copy link
Member

@Atemu Atemu commented Oct 31, 2020

5.9.2 is out and works.

@andresilva andresilva changed the title linux_zen: 5.8.13 -> 5.9.1 linux_zen: 5.8.13 -> 5.9.2 Nov 1, 2020
@andresilva
Copy link
Member Author

@andresilva andresilva commented Nov 1, 2020

@Atemu Updated

@ofborg ofborg bot requested a review from Atemu Nov 1, 2020
@Atemu
Copy link
Member

@Atemu Atemu commented Nov 1, 2020

@andresilva andresilva changed the title linux_zen: 5.8.13 -> 5.9.2 linux_zen: 5.8.13 -> 5.9.3 Nov 1, 2020
@andresilva
Copy link
Member Author

@andresilva andresilva commented Nov 1, 2020

Result of nixpkgs-review pr 100645 1

8 packages marked as broken and skipped:
  • linuxPackages_zen.ixgbevf
  • linuxPackages_zen.lttng-modules
  • linuxPackages_zen.nvidia_x11_legacy304
  • linuxPackages_zen.openafs
  • linuxPackages_zen.phc-intel
  • linuxPackages_zen.rtl8723bs
  • linuxPackages_zen.sch_cake
  • linuxPackages_zen.tbs
21 packages failed to build:
  • linuxPackages_zen.amdgpu-pro
  • linuxPackages_zen.anbox
  • linuxPackages_zen.ati_drivers_x11
  • linuxPackages_zen.broadcom_sta
  • linuxPackages_zen.chipsec
  • linuxPackages_zen.cryptodev
  • linuxPackages_zen.dpdk
  • linuxPackages_zen.ena
  • linuxPackages_zen.evdi
  • linuxPackages_zen.mwprocapture
  • linuxPackages_zen.mxu11x0
  • linuxPackages_zen.ndiswrapper
  • linuxPackages_zen.nvidia_x11_legacy340
  • linuxPackages_zen.nvidia_x11_legacy390
  • linuxPackages_zen.nvidia_x11_vulkan_beta
  • linuxPackages_zen.openafs_1_8
  • linuxPackages_zen.r8168
  • linuxPackages_zen.rtl8814au
  • linuxPackages_zen.rtl8821au
  • linuxPackages_zen.rtl88xxau-aircrack
  • linuxPackages_zen.rtlwifi_new
51 packages built:
  • linuxPackages_zen.acpi_call
  • linuxPackages_zen.asus-wmi-sensors
  • linuxPackages_zen.batman_adv
  • linuxPackages_zen.bbswitch
  • linuxPackages_zen.bcc
  • linuxPackages_zen.bpftrace
  • linuxPackages_zen.can-isotp
  • linuxPackages_zen.cpupower
  • linuxPackages_zen.ddcci-driver
  • linuxPackages_zen.digimend
  • linuxPackages_zen.facetimehd
  • linuxPackages_zen.fwts-efi-runtime
  • linuxPackages_zen.hyperv-daemons
  • linuxPackages_zen.intel-speed-select
  • linuxPackages_zen.it87
  • linuxPackages_zen.jool
  • linuxPackages_zen.kernel
  • linuxPackages_zen.mba6x_bl
  • linuxPackages_zen.netatop
  • linuxPackages_zen.nvidia_x11
  • linuxPackages_zen.nvidiabl
  • linuxPackages_zen.oci-seccomp-bpf-hook
  • linuxPackages_zen.openrazer
  • linuxPackages_zen.perf
  • linuxPackages_zen.ply
  • linuxPackages_zen.r8125
  • linuxPackages_zen.rtl8192eu
  • linuxPackages_zen.rtl8812au
  • linuxPackages_zen.rtl8821ce
  • linuxPackages_zen.rtl8821cu
  • linuxPackages_zen.rtl88x2bu
  • linuxPackages_zen.sysdig
  • linuxPackages_zen.system76
  • linuxPackages_zen.system76-acpi
  • linuxPackages_zen.system76-io
  • linuxPackages_zen.systemtap
  • linuxPackages_zen.tmon
  • linuxPackages_zen.tp_smapi
  • linuxPackages_zen.turbostat
  • linuxPackages_zen.tuxedo-keyboard
  • linuxPackages_zen.usbip
  • linuxPackages_zen.v4l2loopback
  • linuxPackages_zen.v86d
  • linuxPackages_zen.vhba
  • linuxPackages_zen.virtualbox
  • linuxPackages_zen.virtualboxGuestAdditions
  • linuxPackages_zen.x86_energy_perf_policy
  • linuxPackages_zen.xpadneo
  • linuxPackages_zen.zenpower
  • linuxPackages_zen.zfs
  • linuxPackages_zen.zfsUnstable

Atemu
Atemu approved these changes Nov 2, 2020
Copy link
Member

@Atemu Atemu left a comment

Result of nixpkgs-review pr 100645 1

8 packages marked as broken and skipped:
  • linuxPackages_zen.ixgbevf
  • linuxPackages_zen.lttng-modules
  • linuxPackages_zen.nvidia_x11_legacy304
  • linuxPackages_zen.openafs
  • linuxPackages_zen.phc-intel
  • linuxPackages_zen.rtl8723bs
  • linuxPackages_zen.sch_cake
  • linuxPackages_zen.tbs
20 packages failed to build:
  • linuxPackages_zen.amdgpu-pro
  • linuxPackages_zen.anbox
  • linuxPackages_zen.broadcom_sta
  • linuxPackages_zen.chipsec
  • linuxPackages_zen.cryptodev
  • linuxPackages_zen.dpdk
  • linuxPackages_zen.ena
  • linuxPackages_zen.evdi
  • linuxPackages_zen.mwprocapture
  • linuxPackages_zen.mxu11x0
  • linuxPackages_zen.ndiswrapper
  • linuxPackages_zen.nvidia_x11_legacy340
  • linuxPackages_zen.nvidia_x11_legacy390
  • linuxPackages_zen.nvidia_x11_vulkan_beta
  • linuxPackages_zen.openafs_1_8
  • linuxPackages_zen.r8168
  • linuxPackages_zen.rtl8814au
  • linuxPackages_zen.rtl8821au
  • linuxPackages_zen.rtl88xxau-aircrack
  • linuxPackages_zen.rtlwifi_new
51 packages built:
  • linuxPackages_zen.acpi_call
  • linuxPackages_zen.asus-wmi-sensors
  • linuxPackages_zen.batman_adv
  • linuxPackages_zen.bbswitch
  • linuxPackages_zen.bcc
  • linuxPackages_zen.bpftrace
  • linuxPackages_zen.can-isotp
  • linuxPackages_zen.cpupower
  • linuxPackages_zen.ddcci-driver
  • linuxPackages_zen.digimend
  • linuxPackages_zen.facetimehd
  • linuxPackages_zen.fwts-efi-runtime
  • linuxPackages_zen.hyperv-daemons
  • linuxPackages_zen.intel-speed-select
  • linuxPackages_zen.it87
  • linuxPackages_zen.jool
  • linux_zen (linuxPackages_zen.kernel)
  • linuxPackages_zen.mba6x_bl
  • linuxPackages_zen.netatop
  • linuxPackages_zen.nvidia_x11 (linuxPackages_zen.nvidia_x11_beta)
  • linuxPackages_zen.nvidiabl
  • linuxPackages_zen.oci-seccomp-bpf-hook
  • linuxPackages_zen.openrazer
  • linuxPackages_zen.perf
  • linuxPackages_zen.ply
  • linuxPackages_zen.r8125
  • linuxPackages_zen.rtl8192eu
  • linuxPackages_zen.rtl8812au
  • linuxPackages_zen.rtl8821ce
  • linuxPackages_zen.rtl8821cu
  • linuxPackages_zen.rtl88x2bu
  • linuxPackages_zen.sysdig
  • linuxPackages_zen.system76
  • linuxPackages_zen.system76-acpi
  • linuxPackages_zen.system76-io
  • linuxPackages_zen.systemtap
  • linuxPackages_zen.tmon
  • linuxPackages_zen.tp_smapi
  • linuxPackages_zen.turbostat
  • linuxPackages_zen.tuxedo-keyboard
  • linuxPackages_zen.usbip
  • linuxPackages_zen.v4l2loopback
  • linuxPackages_zen.v86d
  • linuxPackages_zen.vhba
  • linuxPackages_zen.virtualbox
  • linuxPackages_zen.virtualboxGuestAdditions
  • linuxPackages_zen.x86_energy_perf_policy
  • linuxPackages_zen.xpadneo
  • linuxPackages_zen.zenpower
  • linuxPackages_zen.zfs (linuxPackages_zen.zfsStable)
  • linuxPackages_zen.zfsUnstable

Everything is working fine.

@Atemu Atemu requested a review from NeQuissimus Nov 2, 2020
@NeQuissimus NeQuissimus merged commit 86542cc into NixOS:master Nov 3, 2020
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants