Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

marker: init at 2020.04.04 #100653

Merged
merged 1 commit into from Oct 29, 2020
Merged

marker: init at 2020.04.04 #100653

merged 1 commit into from Oct 29, 2020

Conversation

@trepetti
Copy link
Contributor

@trepetti trepetti commented Oct 15, 2020

Motivation for this change

Add Marker, a GTK3-based markdown editor for Linux desktops.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@trepetti
Copy link
Contributor Author

@trepetti trepetti commented Oct 15, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Oct 15, 2020
@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Oct 15, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@trepetti
Copy link
Contributor Author

@trepetti trepetti commented Oct 17, 2020

Result of nixpkgs-review pr 100653 1

1 package built:
  • marker
Copy link
Contributor

@r-burns r-burns left a comment

Passes nixpkgs-review on non-nixos linux

pkgs/applications/editors/marker/default.nix Outdated Show resolved Hide resolved
pkgs/applications/editors/marker/default.nix Outdated Show resolved Hide resolved
@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Oct 27, 2020

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be put back in the needs_reviewer queue in one day.

Copy link
Contributor

@r-burns r-burns left a comment

Good bot :)

Since upstream hasn't responded I won't try to hold up this PR any longer. I think the most likely explanation is they intended to use LGPL3+ but accidentally copied the GPL license file. So for now I'll say LGTM 👍

@trepetti trepetti force-pushed the trepetti:marker branch from b507529 to 7559a99 Oct 29, 2020
@r-burns
Copy link
Contributor

@r-burns r-burns commented Oct 29, 2020

/status needs_merger

Copy link
Member

@timokau timokau left a comment

Thanks for the review @r-burns :)

@timokau timokau merged commit aee8263 into NixOS:master Oct 29, 2020
19 checks passed
19 checks passed
@github-actions
tests
Details
@github-actions
action
Details
@ofborg
marker, marker.passthru.tests on aarch64-linux Failure
Details
@ofborg
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions
Wait for ofborg
Details
@ofborg
grahamcofborg-eval ^.^!
Details
@ofborg
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7559a99"; rev="7559a99131a41d23bc084863ef026e18547ac9df"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7559a99"; rev="7559a99131a41d23bc084863ef026e18547ac9df"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7559a99"; rev="7559a99131a41d23bc084863ef026e18547ac9df"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7559a99"; rev="7559a99131a41d23bc084863ef026e18547ac9df"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7559a99"; rev="7559a99131a41d23bc084863ef026e18547ac9df"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7559a99"; rev="7559a99131a41d23bc084863ef026e18547ac9df"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7559a99"; rev="7559a99131a41d23bc084863ef026e18547ac9df"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg
marker, marker.passthru.tests on x86_64-linux Success
Details
@trepetti trepetti deleted the trepetti:marker branch Oct 29, 2020
@alexeymuranov
Copy link
Contributor

@alexeymuranov alexeymuranov commented Nov 30, 2020

Would it be possible to backport it to 20.09? I can try when i have some spare time...

@timokau
Copy link
Member

@timokau timokau commented Nov 30, 2020

I'm not sure what the policy on backporting new packages is. You can mix packages from different channels though (see this discourse thread), so you could still install this on a 20.09 setup. Is that good enough for you?

@alexeymuranov
Copy link
Contributor

@alexeymuranov alexeymuranov commented Dec 1, 2020

@timokau , it would be easier for me to use everything from one channel, i am not a very advanced user.

According to this old message of Vladimír Čunát about stabilising NixOS 18.03, backporting new pacakges seems ok:

What should be cherry-picked?

  • [...]
  • Optionally, new package additions, as that won't break anything.
@trepetti
Copy link
Contributor Author

@trepetti trepetti commented Dec 2, 2020

The most recent maintainers wiki entry says we should probably hold off on backporting the package.

Adding a new channel to nix-env install packages is super easy, though:

nix-channel --add https://nixos.org/channels/nixpkgs-unstable unstable
nix-env -iA unstable.marker

And that should do it. You don't even need to be root.

@alexeymuranov
Copy link
Contributor

@alexeymuranov alexeymuranov commented Dec 2, 2020

@trepetti, this didn't work for me:

$ nix-channel --add https://nixos.org/channels/nixpkgs-unstable unstable
$ nix-env -iA unstable.marker

error: attribute 'unstable' in selection path 'unstable.marker' not found
@trepetti
Copy link
Contributor Author

@trepetti trepetti commented Dec 2, 2020

Then try nix-env -i unstable.marker. You may not be in the nix.allowedUsers list. Also make sure you run nix-channel --update--forgot to mention that.

@alexeymuranov
Copy link
Contributor

@alexeymuranov alexeymuranov commented Dec 3, 2020

@trepetti, yes it was nix-channel --update that was missing, thanks. I said i was not a very advanced user :).

@alexeymuranov
Copy link
Contributor

@alexeymuranov alexeymuranov commented Dec 3, 2020

@trepetti, the problem with having two channels for me is that now i cannot check for upgraded packages in the stable channel with

$ nix-env -u --dry-run

-- it shows everything from the unstable too.

@trepetti
Copy link
Contributor Author

@trepetti trepetti commented Dec 3, 2020

If you are on NixOS, you can have nix-env only upgrade packages using derivations from the default (stable) channel by providing that channel's file:

nix-env -u --dry-run -f ~/.nix-defexpr/channels_root/nixos/default.nix
@alexeymuranov
Copy link
Contributor

@alexeymuranov alexeymuranov commented Dec 3, 2020

@trepetti , thanks. I am on NixOS indeed.

@timokau
Copy link
Member

@timokau timokau commented Dec 4, 2020

@timokau , it would be easier for me to use everything from one channel, i am not a very advanced user.

According to this old message of Vladimír Čunát about stabilising NixOS 18.03, backporting new pacakges seems ok:

That's a good find! Its a little old to base a decision on though. The current guidelines that @alexeymuranov linked don't give any concrete guidance (at least the way I read them). I asked on IRC, but unfortunately didn't get a reply.

@jonringer do you have an opinion on backporting new packages?

@jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 4, 2020

I'm okay with it philosophically. But would prefer people to use unstable when they want the latest of something.

@alexeymuranov
Copy link
Contributor

@alexeymuranov alexeymuranov commented Dec 5, 2020

@jonringer, in my case i do not want the latest, i want any.

@trepetti trepetti mentioned this pull request Dec 6, 2020
3 of 10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants