Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

networkmanager-sstp: init at unstable-2020-04-20, bump sstp from 1.0.12 to 1.0.13 #100657

Merged
merged 3 commits into from Oct 20, 2020

Conversation

@flokli
Copy link
Contributor

@flokli flokli commented Oct 15, 2020

Motivation for this change

Connecting to SSTP VPNs without manually working with sstpc.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

@lovesegfault lovesegfault left a comment

Left a minor nit.

I wish this was made optional, but perhaps that has to happen whenever we make all of NM's plugins optional

c.f. #84433

{ stdenv, fetchFromGitHub, substituteAll, autoreconfHook, sstp, ppp, file, intltool, pkgconfig, networkmanager, libsecret, gtk3
, withGnome ? true, gnome3, fetchpatch, libnma, glib }:
Copy link
Member

@lovesegfault lovesegfault Oct 20, 2020

Wish this was split over a few lines

Copy link
Contributor Author

@flokli flokli Oct 20, 2020

nit adressed.

@flokli flokli force-pushed the network-manager-sstp branch from 5a331d8 to e992089 Oct 20, 2020
@flokli
Copy link
Contributor Author

@flokli flokli commented Oct 20, 2020

Okay, let's get this in, and work on making it optional in #84433, together with all the other plugins.

@flokli flokli merged commit 6e5ccaa into NixOS:master Oct 20, 2020
13 of 16 checks passed
@flokli flokli deleted the network-manager-sstp branch Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants