Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

itk: remove -march=corei7 and -mtune=native flags from cmake build files #100659

Merged
merged 1 commit into from Oct 16, 2020

Conversation

@bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Oct 15, 2020

  • probable cause of build failure on Hydra on branch release-20.09

for ZHF (#97479).

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
- probable cause of build failure on Hydra on branch release-20.09
Copy link
Contributor

@jonringer jonringer left a comment

LGTM

https://github.com/NixOS/nixpkgs/pull/100659
3 packages built:
elastix itk simpleitk

substituteInPlace CMake/ITKSetStandardCompilerFlags.cmake \
--replace "-march=corei7" "" \
--replace "-mtune=native" ""
'';
Copy link
Contributor

@risicle risicle Oct 16, 2020

Surely we need to restrict this to x86_64? ignore me

@risicle
Copy link
Contributor

@risicle risicle commented Oct 16, 2020

WFM macos 10.14. Reverse dependency elastix already broken for darwin.

@risicle risicle merged commit bdb7c69 into NixOS:master Oct 16, 2020
19 checks passed
@bcdarwin bcdarwin deleted the fix-itk-flags branch Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants