Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.pkgs.osmpythontools: 0.2.6 -> 0.2.8 #100661

Merged
merged 1 commit into from Oct 16, 2020
Merged

Conversation

@das-g
Copy link
Member

@das-g das-g commented Oct 15, 2020

Motivation for this change

upstream release

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
    • (there are none)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Note on tests

Since mocnik-science/osm-python-tools@e07ce69, the GitHub repo actually contains automated tests, but

  • releases currently aren't tagged on that repo (mocnik-science/osm-python-tools#25), so we have to either continue to take them from PyPI, or guess the release's commit ID
  • the tests call the actual external services, thus being slow and impure

so for now, I think it's best to not include them in the build of the Nixpkgs derivation.

@das-g das-g requested review from FRidh and jonringer as code owners Oct 15, 2020
@das-g
Copy link
Member Author

@das-g das-g commented Oct 15, 2020

Result of nixpkgs-review pr 100661 1

2 packages built:
  • python37Packages.osmpythontools
  • python38Packages.osmpythontools

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 100661 1

2 packages built:
  • python37Packages.osmpythontools
  • python38Packages.osmpythontools

@jonringer jonringer merged commit 4025239 into NixOS:master Oct 16, 2020
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants