Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noise-suppression-for-voice: init at 2020-10-12 #100688

Merged
merged 1 commit into from Oct 26, 2020
Merged

Conversation

@henrikolsson
Copy link
Contributor

@henrikolsson henrikolsson commented Oct 16, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ajs124
Copy link
Member

@ajs124 ajs124 commented Oct 16, 2020

Did/does this actually work for you? I remember packaging this a while back and trying to use it with pulseaudio, because I was really impressed with RNNoise in mumble, but couldn't get it to work.

@henrikolsson
Copy link
Contributor Author

@henrikolsson henrikolsson commented Oct 17, 2020

Did/does this actually work for you? I remember packaging this a while back and trying to use it with pulseaudio, because I was really impressed with RNNoise in mumble, but couldn't get it to work.

Yes, it works for me. Using it as suggested in the readme with pulseaudio loopback and monitor. My ~/.config/pulse/default.pa:

.include /etc/pulse/default.pa

load-module module-null-sink sink_name=mic_denoised_out rate=48000
load-module module-ladspa-sink sink_name=mic_raw_in sink_master=mic_denoised_out label=noise_suppressor_mono plugin=/home/henrik/src/nix/noise-suppression-for-voice/result/lib/ladspa/librnnoise_ladspa.so control=50
load-module module-loopback source=alsa_input.usb-ZOOM_Corporation_H1n_000000000000-00.analog-stereo sink=mic_raw_in channels=1 source_dont_move=true sink_dont_move=true latency_msec=1

set-default-source mic_denoised_out.monitor

In what way didn't it work for you?

@srhb
Copy link
Contributor

@srhb srhb commented Oct 19, 2020

@ofborg eval

Copy link
Contributor

@srhb srhb left a comment

Thank you for your contribution! I've added a few requests for adjustments that I hope you're up for. :)

Also, let's see how ofborg feels about the platforms before merging with all

@srhb
Copy link
Contributor

@srhb srhb commented Oct 19, 2020

@ofborg build noise-suppression-for-voice

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@srhb
Copy link
Contributor

@srhb srhb commented Oct 19, 2020

@ofborg build noise-supression-for-voice

srhb
srhb approved these changes Oct 26, 2020
Copy link
Contributor

@srhb srhb left a comment

Thanks for the fixups!

@srhb srhb merged commit d699505 into NixOS:master Oct 26, 2020
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants