Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator-sdk: 1.0.1 -> 1.1.0 #100695

Merged
merged 1 commit into from Nov 3, 2020
Merged

operator-sdk: 1.0.1 -> 1.1.0 #100695

merged 1 commit into from Nov 3, 2020

Conversation

@anpryl
Copy link
Contributor

@anpryl anpryl commented Oct 16, 2020

Motivation for this change

Updating operator-sdk to latest release

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@anpryl
Copy link
Contributor Author

@anpryl anpryl commented Nov 3, 2020

gentle reminder @kalbasit @doronbehar

@doronbehar doronbehar merged commit 65f4c39 into NixOS:master Nov 3, 2020
19 checks passed
@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Nov 3, 2020

FYI @kalbasit is requested for a review for every buildGoModule usage (I don't know why) so he's not someone to ask for a review for such a simple version bump as this. As for myself, I'm not using this package at all and I don't know it so I don't know why you requested my review but I didn't mind hit the button.

@kalbasit
Copy link
Member

@kalbasit kalbasit commented Nov 3, 2020

@doronbehar that's because I'm in the OWNERS file for Go modules as well as the default maintainer for Go modules. Thanks for merging this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants