Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdfjs: 2.4.456 -> 2.6.347 #100702

Merged
merged 1 commit into from Oct 16, 2020
Merged

pdfjs: 2.4.456 -> 2.6.347 #100702

merged 1 commit into from Oct 16, 2020

Conversation

@emmanuelrosa
Copy link
Contributor

@emmanuelrosa emmanuelrosa commented Oct 16, 2020

Motivation for this change

This is a qutebrowser (and the bundled pdfjs) version bump.

This is a version bump for the pdfjs bundled with qutebrowser.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Oct 16, 2020

Qutebrowser was updated to 1.14 in 0ff5728, so you should only pick the pdf.js update. I'm not sure how this PR is not conflicting, though.

@emmanuelrosa emmanuelrosa force-pushed the qutebrowser-1.14.0 branch from 65fdd09 to 72f0938 Oct 16, 2020
@emmanuelrosa emmanuelrosa changed the title Qutebrowser 1.14.0 pdfjs: 2.4.456 -> 2.6.347 Oct 16, 2020
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Looks good. Thank you!

@rnhmjoj rnhmjoj merged commit 51b2e7a into NixOS:master Oct 16, 2020
17 checks passed
@emmanuelrosa emmanuelrosa deleted the qutebrowser-1.14.0 branch Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants