Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

krita: 4.3.0 -> 4.4.0 #100711

Merged
merged 1 commit into from Oct 25, 2020
Merged

krita: 4.3.0 -> 4.4.0 #100711

merged 1 commit into from Oct 25, 2020

Conversation

@nek0
Copy link
Contributor

@nek0 nek0 commented Oct 16, 2020

Motivation for this change

Krita 4.4.0 has been out for a while now and proven to be stable.

@abbradar I hope this suffices.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
ajs124
ajs124 approved these changes Oct 16, 2020
Copy link
Member

@ajs124 ajs124 left a comment

Changelog for reference: https://krita.org/en/krita-4-4-0-release-notes/
Builds and runs fine in a short test.

@FRidh FRidh merged commit a14611b into NixOS:master Oct 25, 2020
19 checks passed
19 checks passed
@github-actions[bot]
tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
krita, krita.passthru.tests on aarch64-linux Failure
Details
@ofborg[bot]
krita, krita.passthru.tests on x86_64-linux Timed out, unknown build status
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a5f0f00"; rev="a5f0f00c3ca9e3324fa413a9b30fdd6e2d52181e"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a5f0f00"; rev="a5f0f00c3ca9e3324fa413a9b30fdd6e2d52181e"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a5f0f00"; rev="a5f0f00c3ca9e3324fa413a9b30fdd6e2d52181e"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a5f0f00"; rev="a5f0f00c3ca9e3324fa413a9b30fdd6e2d52181e"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a5f0f00"; rev="a5f0f00c3ca9e3324fa413a9b30fdd6e2d52181e"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a5f0f00"; rev="a5f0f00c3ca9e3324fa413a9b30fdd6e2d52181e"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a5f0f00"; rev="a5f0f00c3ca9e3324fa413a9b30fdd6e2d52181e"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants