Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boolector: enable darwin build #100750

Merged
merged 2 commits into from Dec 2, 2020
Merged

boolector: enable darwin build #100750

merged 2 commits into from Dec 2, 2020

Conversation

@arcz
Copy link
Member

@arcz arcz commented Oct 16, 2020

Motivation for this change

The build was working only on linux. For darwin, it required some dynamic library path patching since the default build doesn't set them correctly.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@arcz arcz requested a review from LnL7 Nov 29, 2020
@arcz
Copy link
Member Author

@arcz arcz commented Nov 29, 2020

@LnL7 I've changed this PR considerably based on your comments

@thoughtpolice thoughtpolice merged commit a3ae8a4 into NixOS:master Dec 2, 2020
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants