Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python{2,3}Packages.galario: 1.2.1 -> 1.2.2 #100767

Merged
merged 1 commit into from Oct 17, 2020
Merged

Conversation

@jfroche
Copy link
Contributor

@jfroche jfroche commented Oct 16, 2020

Upgrading fixes the tests

fix https://hydra.nixos.org/build/127623662

ZHF: #97479
cc @NixOS/nixos-release-managers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@jfroche
Copy link
Contributor Author

@jfroche jfroche commented Oct 16, 2020

Result of nixpkgs-review pr 100767 1

4 packages built:
  • galario
  • python27Packages.galario
  • python37Packages.galario
  • python38Packages.galario

Copy link
Contributor

@jonringer jonringer left a comment

When backporting changes, please follow https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#backporting-changes.

Namely, you should be doing git cherry-pick -x <rev> from a commit that has already landed in master. If the branches have diverged, you may alter the commit or add another commit to ensure that the package is able to still evaluate and build

@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 17, 2020

disregard previous comment, thought this was against 20.09

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 100767 1

4 packages built:
  • galario
  • python27Packages.galario
  • python37Packages.galario
  • python38Packages.galario

@jonringer jonringer merged commit 9cbbac9 into NixOS:master Oct 17, 2020
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants