Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.block-io: fix build #100768

Merged
merged 1 commit into from Oct 21, 2020
Merged

python3Packages.block-io: fix build #100768

merged 1 commit into from Oct 21, 2020

Conversation

@jfroche
Copy link
Contributor

@jfroche jfroche commented Oct 16, 2020

Fix base58 dependency and remove Python 2 support

Fix build https://hydra.nixos.org/build/127631234

ZHF: #97479
@NixOS/nixos-release-managers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@jfroche
Copy link
Contributor Author

@jfroche jfroche commented Oct 16, 2020

Result of nixpkgs-review pr 100768 1

2 packages built:
  • python37Packages.block-io
  • python38Packages.block-io

@jfroche
Copy link
Contributor Author

@jfroche jfroche commented Oct 18, 2020

Result of nixpkgs-review pr 100768 1

2 packages built:
  • python37Packages.block-io
  • python38Packages.block-io

@jfroche jfroche requested review from jonringer and risicle Oct 18, 2020
Fix base58 dependency.
Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 100768 1

2 packages built:
  • python37Packages.block-io
  • python38Packages.block-io

@jonringer jonringer merged commit 37740ec into NixOS:master Oct 21, 2020
17 checks passed
17 checks passed
@github-actions[bot]
tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8ec7314"; rev="8ec7314a2447de45b5095c181f067edda9ed82d6"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8ec7314"; rev="8ec7314a2447de45b5095c181f067edda9ed82d6"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8ec7314"; rev="8ec7314a2447de45b5095c181f067edda9ed82d6"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8ec7314"; rev="8ec7314a2447de45b5095c181f067edda9ed82d6"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8ec7314"; rev="8ec7314a2447de45b5095c181f067edda9ed82d6"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8ec7314"; rev="8ec7314a2447de45b5095c181f067edda9ed82d6"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8ec7314"; rev="8ec7314a2447de45b5095c181f067edda9ed82d6"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants