Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python37Packages.dask-ml: 1.6.0 -> 1.7.0 #100772

Closed

Conversation

@r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Oct 16, 2020

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for python37Packages.dask-ml is: "Scalable Machine Learn with Dask"

meta.homepage for python37Packages.dask-ml is: "https://github.com/dask/dask-ml"

meta.changelog for python37Packages.dask-ml is: ""

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact
Checks done (click to expand)

Rebuild report (if merged into master) (click to expand)
6 total rebuild path(s)

2 package rebuild(s)

2 x86_64-linux rebuild(s)
0 i686-linux rebuild(s)
2 x86_64-darwin rebuild(s)
2 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
python37Packages.dask-ml
python38Packages.dask-ml
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/1001qrrvkhkvxlg03jh92fy6pacj35bh-python3.7-dask-ml-1.7.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A python37Packages.dask-ml https://github.com/r-ryantm/nixpkgs/archive/3c2e02e1cdb64d1a78d30feb5dea61da5de88ba8.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/1001qrrvkhkvxlg03jh92fy6pacj35bh-python3.7-dask-ml-1.7.0
ls -la /nix/store/1001qrrvkhkvxlg03jh92fy6pacj35bh-python3.7-dask-ml-1.7.0/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review 1

2 packages built:
  • python37Packages.dask-ml
  • python38Packages.dask-ml

Maintainer pings

cc @costrouc for testing.

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Oct 21, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/improve-a-pkgs-tests-for-nixpkgs-update/9530/14

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 27, 2020

Result of nixpkgs-review pr 100772 run on x86_64-darwin 1

2 packages failed to build:
  • python37Packages.dask-ml
  • python38Packages.dask-ml
Check whether the following modules can be imported: dask_ml dask_ml.naive_bayes dask_ml.wrappers dask_ml.utils
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "<string>", line 1, in <lambda>
  File "/nix/store/0mabx9absir73mmijrsv0dsyvyya463r-python3-3.8.6/lib/python3.8/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 783, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/nix/store/vjvavkpj7hvwfhp94pyia336zlprawh5-python3.8-dask-ml-1.7.0/lib/python3.8/site-packages/dask_ml/__init__.py", line 4, in <module>
    from dask_ml.model_selection import _normalize
  File "/nix/store/vjvavkpj7hvwfhp94pyia336zlprawh5-python3.8-dask-ml-1.7.0/lib/python3.8/site-packages/dask_ml/model_selection/__init__.py", line 6, in <module>
    from ._hyperband import HyperbandSearchCV
  File "/nix/store/vjvavkpj7hvwfhp94pyia336zlprawh5-python3.8-dask-ml-1.7.0/lib/python3.8/site-packages/dask_ml/model_selection/_hyperband.py", line 12, in <module>
    from ._incremental import BaseIncrementalSearchCV
  File "/nix/store/vjvavkpj7hvwfhp94pyia336zlprawh5-python3.8-dask-ml-1.7.0/lib/python3.8/site-packages/dask_ml/model_selection/_incremental.py", line 15, in <module>
    import dask.dataframe as dd
  File "/nix/store/s5hxqfp1nj5wbqajizxiimkwiz8c5rir-python3.8-dask-2.25.0/lib/python3.8/site-packages/dask/dataframe/__init__.py", line 13, in <module>
    from .io import (
  File "/nix/store/s5hxqfp1nj5wbqajizxiimkwiz8c5rir-python3.8-dask-2.25.0/lib/python3.8/site-packages/dask/dataframe/io/__init__.py", line 13, in <module>
    from .csv import read_csv, to_csv, read_table, read_fwf
  File "/nix/store/s5hxqfp1nj5wbqajizxiimkwiz8c5rir-python3.8-dask-2.25.0/lib/python3.8/site-packages/dask/dataframe/io/csv.py", line 387, in <module>
    AUTO_BLOCKSIZE = auto_blocksize(TOTAL_MEM, CPU_COUNT)
  File "/nix/store/s5hxqfp1nj5wbqajizxiimkwiz8c5rir-python3.8-dask-2.25.0/lib/python3.8/site-packages/dask/dataframe/io/csv.py", line 377, in auto_blocksize
    blocksize = int(total_memory // cpu_count / memory_factor)
TypeError: unsupported operand type(s) for //: 'int' and 'NoneType'

@dotlambda
Copy link
Member

@dotlambda dotlambda commented Feb 5, 2021

dask-ml is on version 1.7.0 on master

@dotlambda dotlambda closed this Feb 5, 2021
@r-ryantm r-ryantm deleted the auto-update/python3.7-dask-ml branch Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants