Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpcs3: 0.0.8-9300-341fdf7eb -> 0.0.12-10811-a86a3d2fe #100773

Merged
merged 2 commits into from Dec 13, 2020
Merged

Conversation

@neonfuz
Copy link
Contributor

@neonfuz neonfuz commented Oct 16, 2020

Motivation for this change

Version bump

I defined RPCS3_GIT_FULL_BRANCH="RPCS3/rpcs3/master" because rpcs3 now warns that you're using an unofficial build if the string isn't set to this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Nov 15, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/371

@44100hertz
Copy link

@44100hertz 44100hertz commented Nov 22, 2020

I tested this build of 0.0.12 with Demon's Souls and it is working correctly.

@neonfuz
Copy link
Contributor Author

@neonfuz neonfuz commented Nov 22, 2020

@abbradar are you going to review this? If not I'll add myself as a maintainer, it's been months with no updates on this package.

@petabyteboy petabyteboy merged commit 58cb538 into NixOS:master Dec 13, 2020
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants