Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

singularity: 3.6.3 -> 3.6.4 #100777

Merged
merged 1 commit into from Nov 5, 2020
Merged

singularity: 3.6.3 -> 3.6.4 #100777

merged 1 commit into from Nov 5, 2020

Conversation

@jbedo
Copy link
Contributor

@jbedo jbedo commented Oct 17, 2020

Important security release addressing CVE-2020-15229.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@jbedo
Copy link
Contributor Author

@jbedo jbedo commented Oct 18, 2020

Important security release addressing CVE-2020-15229.
@jbedo
Copy link
Contributor Author

@jbedo jbedo commented Nov 1, 2020

Can we revisit this? The CVE it addresses is critical and @AndersonTorres has already merged this update into 20.09 (#100896) so unstable is currently behind 20.09.

@markuskowa
Copy link
Member

@markuskowa markuskowa commented Nov 5, 2020

I am not aware that that the sha256 is supposed to be changed. Can we just keep it in the traditional format?

@jbedo
Copy link
Contributor Author

@jbedo jbedo commented Nov 5, 2020

oops i forgot to push :\

@markuskowa markuskowa merged commit b580137 into NixOS:master Nov 5, 2020
19 checks passed
@AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Nov 7, 2020

@markuskowa the new format is optional for now. We are slowly converting all of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants