Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpvScripts.mpris: fix build #100779

Merged
merged 1 commit into from Nov 27, 2020
Merged

mpvScripts.mpris: fix build #100779

merged 1 commit into from Nov 27, 2020

Conversation

@lukebfox
Copy link
Member

@lukebfox lukebfox commented Oct 17, 2020

Motivation for this change

#100771

Things done

Updated derivation argument to be more in line with wrapper methodology.
Tested mpv wrapped with mpris and it builds and works.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Oct 17, 2020

Thanks for the fix! Could please only change the commit message to:

mpvScripts.mpris: Use mpv-unwrapped

Needed after #88620 to fix evaluation in some cases. Fixes #100771

Needed after NixOS#88620 to fix evaluation in some cases. Fixes NixOS#100771
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 27, 2020

Result of nixpkgs-review pr 100779 run on x86_64-linux 1

1 package built:
  • mpvScripts.mpris

@SuperSandro2000 SuperSandro2000 merged commit 978f570 into NixOS:master Nov 27, 2020
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants