Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.snowflake-connector-python: 2.3.2 -> 2.3.3 #100783

Merged
merged 1 commit into from Oct 17, 2020

Conversation

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 17, 2020

Fixes the build by relaxing the boto version pin.

Motivation for this change

Noticed it was broken in #100762

Tried to get the tests running, but they require secret parameters....

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Fixes the build by relaxing the boto version pin.
Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 100783 1

4 packages built:
  • python37Packages.snowflake-connector-python
  • python37Packages.snowflake-sqlalchemy
  • python38Packages.snowflake-connector-python
  • python38Packages.snowflake-sqlalchemy

@jonringer jonringer merged commit 41ef4f8 into NixOS:master Oct 17, 2020
17 checks passed
@mweinelt mweinelt deleted the python/snowflake-connector branch Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants