Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

knightos platforms #100804

Merged
merged 1 commit into from Oct 17, 2020
Merged

knightos platforms #100804

merged 1 commit into from Oct 17, 2020

Conversation

@siraben
Copy link
Member

@siraben siraben commented Oct 17, 2020

Motivation for this change

@danieldk's suggestion to add meta.platforms (not already enforced by ofborg?)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@siraben
Copy link
Member Author

@siraben siraben commented Oct 17, 2020

Oops, botched the branch, will rebase. Apologies for the mass ping to reviewers.

@siraben siraben force-pushed the knightos-platforms branch from eed39d0 to f447d36 Oct 17, 2020
@siraben siraben changed the title Knightos platforms knightos platforms Oct 17, 2020
@zowoq zowoq removed their request for review Oct 17, 2020
Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Automatic merge went well; stopped before committing as requested
Nothing to be built.
https://github.com/NixOS/nixpkgs/pull/100804
$ nix-shell /home/jon/.cache/nixpkgs-review/pr-100804/shell.nix

@jonringer jonringer merged commit 3ed43ea into NixOS:master Oct 17, 2020
17 checks passed
17 checks passed
@github-actions[bot]
tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f447d36"; rev="f447d360b5ed809b926fc3616d2ba637260105d1"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f447d36"; rev="f447d360b5ed809b926fc3616d2ba637260105d1"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f447d36"; rev="f447d360b5ed809b926fc3616d2ba637260105d1"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f447d36"; rev="f447d360b5ed809b926fc3616d2ba637260105d1"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f447d36"; rev="f447d360b5ed809b926fc3616d2ba637260105d1"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f447d36"; rev="f447d360b5ed809b926fc3616d2ba637260105d1"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f447d36"; rev="f447d360b5ed809b926fc3616d2ba637260105d1"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@siraben siraben deleted the knightos-platforms branch Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants