Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imv: enable LIBNSGIF and LIBJPEG backends #100821

Merged
merged 1 commit into from Oct 19, 2020
Merged

Conversation

@markus1189
Copy link
Contributor

@markus1189 markus1189 commented Oct 17, 2020

Motivation for this change

Enables two backends that have been disabled previously, libnsgif and libjpeg-turbo. Especially the latter yields MUCH better performance when viewing large jpeg files.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ofborg ofborg bot requested a review from rnhmjoj Oct 17, 2020
@ofborg ofborg bot requested a review from rnhmjoj Oct 18, 2020
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Thank you! Looks good.

@rnhmjoj rnhmjoj merged commit 50ee62a into NixOS:master Oct 19, 2020
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants