Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodePackages.coc-diagnostic: init at 0.9.0 #100822

Merged
merged 1 commit into from Oct 17, 2020

Conversation

@expipiplus1
Copy link
Contributor

@expipiplus1 expipiplus1 commented Oct 17, 2020

Also add as Vim plugin

Also update node packages from generate.sh

Have Tested vim plugin, haven't tested every other node plugin

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Also add as Vim plugin

Also update node packages from generate.sh
@expipiplus1
Copy link
Contributor Author

@expipiplus1 expipiplus1 commented Oct 17, 2020

I followed the instructions in the nodePackges readme, but isn't it a bit odd that to add this package I end up updating all the node packages?

@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 17, 2020

I followed the instructions in the nodePackges readme, but isn't it a bit odd that to add this package I end up updating all the node packages?

this is done so that the node packages can be "shared" with other packages which also use node packages

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 100822 1

2 packages marked as broken and skipped:
  • image_optim
  • ripcord
13 packages built:
  • emojione
  • epgstation
  • joplin
  • lumo
  • mirakurun
  • netlify-cli
  • redoc-cli
  • thelounge
  • twemoji-color-font
  • vimPlugins.coc-diagnostic
  • vimPlugins.coc-prettier
  • vimPlugins.coc-stylelint
  • wasm-text-gen

@jonringer jonringer merged commit 0e29b48 into NixOS:master Oct 17, 2020
17 checks passed
@expipiplus1 expipiplus1 deleted the joe-coc-diagnostic branch Oct 17, 2020
@expipiplus1
Copy link
Contributor Author

@expipiplus1 expipiplus1 commented Oct 17, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants