Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nim: 1.2.6 -> 1.4.0 #100826

Merged
merged 2 commits into from Nov 26, 2020
Merged

nim: 1.2.6 -> 1.4.0 #100826

merged 2 commits into from Nov 26, 2020

Conversation

@ehmry
Copy link
Member

@ehmry ehmry commented Oct 17, 2020

Motivation for this change

Nim 1.4.0 is out. This version was added at bb99a0d but reverted at bce139d when the source tarball was replaced. The new tarball no longer bundles the nimble utility (missing from nim-unwrapped), so this will need to be package seperately and included with the nim package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@petabyteboy
Copy link
Member

@petabyteboy petabyteboy commented Oct 25, 2020

The hash in this commit seems to be wrong. Did the tarball change again?

hash mismatch in fixed-output derivation '/nix/store/q91m00l6dkljka4rqqrm606w4wq0ycps-nim-1.4.0.tar.xz':
  wanted: sha256:0pch14xkymzhrkmyai8i5fcjaxicgjgbzyk3vph6qzvkdfmj0cdy
  got:    sha256:0gf2lqkqzai6mg7mf4y04gdy1ddiavans09i8aisa88ssfza5ywx

@petabyteboy
Copy link
Member

@petabyteboy petabyteboy commented Oct 25, 2020

@ehmry do you still have the source tarball with sha256 0pch14xkymzhrkmyai8i5fcjaxicgjgbzyk3vph6qzvkdfmj0cdy in your store? If so, can you diff the contents of this and the new one?
If they keep changing it we should switch to pulling the sources directly from a git checkout/tarball maybe? CC @dom96

@ehmry
Copy link
Member Author

@ehmry ehmry commented Oct 26, 2020

@petabyteboy I do not. If this is how they are going to do releases then we should stay one version behind.

@akavel
Copy link
Contributor

@akavel akavel commented Nov 25, 2020

Hi! @ehmry @petabyteboy is there a chance this will get merged, or not until next version is out (which may be unspecified time in the future)? would there be higher chance if this expression was changed to build from github sources? I kinda miss Nim 1.4, and I wonder if there's a way I (or someone else) could help things advance...

@petabyteboy
Copy link
Member

@petabyteboy petabyteboy commented Nov 25, 2020

Seems like they haven't switched out the release tarball since I last checked a month ago, so we could probably go ahead with nim. I pushed the new hash to this branch. Still need to package nimble seperately.

@kamilchm
Copy link
Member

@kamilchm kamilchm commented Nov 26, 2020

Can we leave nimble as is here, and extract it later?

@petabyteboy
Copy link
Member

@petabyteboy petabyteboy commented Nov 26, 2020

Can we leave nimble as is here, and extract it later?

After this change nimble isn't packaged at all. This would be very confusing to me as a user when I'm used to having nimble installed as part of the nim package.

@ehmry
Copy link
Member Author

@ehmry ehmry commented Nov 26, 2020

I think packaging nimble separately is momentarily confusing but inevitable.

@ehmry
Copy link
Member Author

@ehmry ehmry commented Nov 26, 2020

Actually not a problem, I will package nimble seperately from the unwrapped compiler and combine it into the wrapper.

ehmry added 2 commits Nov 26, 2020
Build Nim with a second fixed-input hash for 1.4.0.
The Nimble utility is no longer bundled with nim-unwrapped.
@ehmry ehmry marked this pull request as ready for review Nov 26, 2020
@ehmry ehmry requested review from petabyteboy, kamilchm and akavel Nov 26, 2020
@petabyteboy petabyteboy merged commit bb7b1b5 into NixOS:master Nov 26, 2020
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants