Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feh: fix build on darwin #100869

merged 1 commit into from Oct 18, 2020

feh: fix build on darwin #100869

merged 1 commit into from Oct 18, 2020


Copy link

@r-burns r-burns commented Oct 17, 2020

Darwin doesn't support inotify, needed for autoreload

Motivation for this change

ZHF 20.09 #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
Darwin doesn't support inotify, needed for autoreload
Copy link

@risicle risicle commented Oct 18, 2020

WFM macos 10.14

@risicle risicle merged commit 1315c20 into NixOS:master Oct 18, 2020
19 checks passed
@r-burns r-burns deleted the feh branch Oct 18, 2020
@r-burns r-burns mentioned this pull request Oct 18, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants