Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cairo: fix build on darwin #100886

Merged
merged 1 commit into from Oct 20, 2020
Merged

cairo: fix build on darwin #100886

merged 1 commit into from Oct 20, 2020

Conversation

@r-burns
Copy link
Contributor

@r-burns r-burns commented Oct 17, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@zowoq
Copy link
Contributor

@zowoq zowoq commented Oct 17, 2020

@ofborg eval

marsam
marsam approved these changes Oct 18, 2020
@eraserhd
Copy link
Contributor

@eraserhd eraserhd commented Oct 18, 2020

This worked for me. Updated nixpkgs to master this afternoon, cairo did not build without this and did build with this, on Mac OS.

@vcunat vcunat merged commit 8bdf7dc into NixOS:master Oct 20, 2020
19 checks passed
@r-burns r-burns deleted the cairo branch Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants