Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navi: 2.12.0 -> 2.12.1 #100889

Merged
merged 1 commit into from Oct 17, 2020
Merged

navi: 2.12.0 -> 2.12.1 #100889

merged 1 commit into from Oct 17, 2020

Conversation

@cust0dian
Copy link
Contributor

@cust0dian cust0dian commented Oct 17, 2020

Motivation for this change

https://github.com/denisidoro/navi/releases/tag/v2.12.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@zowoq
Copy link
Contributor

@zowoq zowoq commented Oct 17, 2020

@ofborg eval

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 17, 2020

LGTM.

Result of nixpkgs-review pr 100889 1

1 package built:
  • navi

@mweinelt mweinelt merged commit d01b2e5 into NixOS:master Oct 17, 2020
2 of 4 checks passed
2 of 4 checks passed
@github-actions[bot]
tests
Details
@github-actions[bot]
action
Details
@github-actions[bot]
Wait for ofborg This failed status will be cleared when ofborg finishes eval.
Details
@ofborg[bot]
grahamcofborg-eval Checking new out paths
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants