Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

powertop: strip hcitool FSH path #100891

Merged
merged 1 commit into from Nov 27, 2020
Merged

powertop: strip hcitool FSH path #100891

merged 1 commit into from Nov 27, 2020

Conversation

@lukebfox
Copy link
Member

@lukebfox lukebfox commented Oct 17, 2020

Motivation for this change

Fix #99492

Does nothing for installing the bluez package which contains hcitools. There is an existing example of this in this package, with xset. Precedence seems that the user is responsible for these runtime dependencies if they want them? cc @fpletz

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@zowoq
Copy link
Contributor

@zowoq zowoq commented Oct 17, 2020

@ofborg eval

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 27, 2020

Result of nixpkgs-review pr 100891 run on x86_64-linux 1

1 package built:
  • powertop

@SuperSandro2000 SuperSandro2000 merged commit be36f6f into NixOS:master Nov 27, 2020
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants