Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement splitString using builtins.split #100953

Merged
merged 1 commit into from Oct 20, 2020
Merged

Conversation

@AtnNn
Copy link
Contributor

@AtnNn AtnNn commented Oct 18, 2020

Motivation for this change

splitString was slow and crashed on large strings, but it is still used over a hundred times in nixpkgs. Previously mentioned in:

Things done
  • Ran nix-instantiate --eval --strict lib/tests/misc.nix
@AtnNn AtnNn requested review from edolstra, Infinisil and nbp as code owners Oct 18, 2020
lib/strings.nix Outdated Show resolved Hide resolved
lib/default.nix Outdated Show resolved Hide resolved
Copy link
Member

@Infinisil Infinisil left a comment

Nice work!

@Infinisil Infinisil merged commit a2fe9a7 into NixOS:master Oct 20, 2020
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants