Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sayonara: 1.5.1-stable5 -> 1.6.0-beta6 #100969

Merged
merged 1 commit into from Oct 19, 2020
Merged

Conversation

@peterhoeg
Copy link
Member

@peterhoeg peterhoeg commented Oct 18, 2020

Motivation for this change

I'm aware that we don't normally upgrade from stable to betas but in
this case:

  1. the out-of-the-box experience is much better as the skeleton DB
    copied over on first run now has the proper permissions
  2. we can drop all our iffy patching

And let's face it - it's a music player. If it breaks somebody's special
use-case, there's about a million alternatives.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

@aanderse aanderse left a comment

LGTM 👍

@peterhoeg peterhoeg merged commit 7944ac9 into NixOS:master Oct 19, 2020
19 checks passed
@peterhoeg peterhoeg deleted the u/sayonara_1_6_0b6 branch Oct 19, 2020
@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented May 10, 2021

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/how-to-configure-sayonara-in-nixos/12989/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants