Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freecad: add missing python package #100972

Merged
merged 4 commits into from Oct 18, 2020
Merged

freecad: add missing python package #100972

merged 4 commits into from Oct 18, 2020

Conversation

@gebner
Copy link
Member

@gebner gebner commented Oct 18, 2020

Motivation for this change

The addon manager failed to update the addon list, because GitPython was missing. Maybe we should switch to a separate wrapper package at some point, but I haven't got the time for that atm.

The first commit should be ported back to stable.

I've also removed the freecadStable package, which no longer builds since qtwebkit has been marked insecure.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ofborg ofborg bot requested a review from viric Oct 18, 2020
@gebner gebner merged commit 7caa81d into NixOS:master Oct 18, 2020
19 checks passed
@gebner
Copy link
Member Author

@gebner gebner commented Oct 18, 2020

Cherry picked as 43e8ec4.

@gebner gebner mentioned this pull request Nov 12, 2020
68 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant