Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mp3gain: Fix vulnerabilities #100980

Merged
merged 1 commit into from Dec 27, 2020
Merged

Conversation

@devhell
Copy link
Contributor

@devhell devhell commented Oct 18, 2020

This patch has been fetched from SuSE1 and addresses various security
vulnerabilities.

This commit should also close #90893

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@devhell devhell closed this Nov 15, 2020
@devhell devhell deleted the patch-mp3gain-cve-2019-18359 branch Nov 15, 2020
@devhell devhell restored the patch-mp3gain-cve-2019-18359 branch Nov 15, 2020
@devhell
Copy link
Contributor Author

@devhell devhell commented Nov 15, 2020

Sorry, closed by mistake.

@devhell devhell reopened this Nov 15, 2020
pkgs/applications/audio/mp3gain/default.nix Outdated Show resolved Hide resolved
This commit fetches a patch for CVE-2019-18359 from Gentoo's repository
[1]. Previously openSuSE[2] was used, but that did not work well with
`fetchpatch` and having copies of patches is discouraged.

This commit should also close NixOS#90893

[1]:
https://gitweb.gentoo.org/repo/gentoo.git/commit/media-sound/mp3gain?id=36f8689f7903548f5d89827a6e7bdf70a9882cee
[2]:
https://build.opensuse.org/package/view_file/openSUSE:Factory/mp3gain/0001-fix-security-bugs.patch
@devhell devhell force-pushed the patch-mp3gain-cve-2019-18359 branch from 239d2f6 to 487fb29 Dec 27, 2020
@devhell devhell requested a review from doronbehar Dec 27, 2020
@doronbehar doronbehar merged commit a56f793 into NixOS:master Dec 27, 2020
19 checks passed
@devhell devhell deleted the patch-mp3gain-cve-2019-18359 branch Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants